Skip to content

fix: show ingestion error inline on failed Knowledge table rows #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thenathanb wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −2
Open

fix: show ingestion error inline on failed Knowledge table rows #2348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
581e743
Show ingestion error inline on failed Knowledge table rows
Thenathanb Sep 9, 2026
3af5e4f
Merge branch 'main' into knowledge-table-inline-error-tooltip
Thenathanb Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions frontend/app/knowledge/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ function SearchPage() {
}

if (status === "failed") {
return (
const button = (
<button
type="button"
className={cn(
Expand All @@ -776,7 +776,11 @@ function SearchPage() {
? "text-destructive hover:opacity-80"
: "w-full text-red-500 hover:text-red-400",
)}
aria-label="View ingestion error"
aria-label={
data?.error
? `View ingestion error: ${data.error}`
: "View ingestion error"
}
data-testid="failed-status-cell-trigger"
onClick={() => {
selectTask(getTaskIdForRow(data));
Expand All @@ -787,6 +791,23 @@ function SearchPage() {
<StatusBadge status={status} className="pointer-events-none" />
</button>
);

if (!data?.error) {
return button;
}

return (
<Tooltip>
<TooltipTrigger asChild>{button}</TooltipTrigger>
<TooltipContent
side="top"
align="end"
className="max-w-80 whitespace-pre-wrap break-words"
>
{data.error}

@mfortman11 mfortman11 Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium Issue
Resolve task errors before rendering the tooltip —

When a legacy/provider failure supplies wrapped JSON in fileInfo.error, TaskContext copies that raw value into data.error, whereas the Task dialog passes it through resolveTaskFileError and formatProviderErrorMessage. Rendering data.error directly therefore shows raw backend payloads instead of the resolved user-facing message promised by this change; apply the same resolution used by the dialog.

</TooltipContent>
</Tooltip>
);
}

return <StatusBadge status={status} />;
Expand Down
Loading