Skip to content

[Merged by Bors] - chore(Order/Defs/Unbundled): deprecate IsTotal in favor of core's Std.Total - #33797

Closed
SnirBroshi wants to merge 8 commits into
leanprover-community:masterfrom
SnirBroshi:chore/relation-duplication/is-total
Closed

[Merged by Bors] - chore(Order/Defs/Unbundled): deprecate IsTotal in favor of core's Std.Total#33797
SnirBroshi wants to merge 8 commits into
leanprover-community:masterfrom
SnirBroshi:chore/relation-duplication/is-total

Conversation

@SnirBroshi

Copy link
Copy Markdown
Collaborator

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

PR summary f3cf88f5ce

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Colex.total_le
+ LE.total
+ Lex.total_le
+ LowerSet.total_le
+ OrderDual.total_le
+ Prop.le_total
+ Std.Total.decide
+ Std.Total.directed
+ Std.Total.isTrichotomous
+ Std.Total.swap
+ UpperSet.total_le
+ additive_of_isTotal
+ additive_of_symmetric_of_isTotal
+ compRel_of_total
+ instTotal
+ instance (priority := 100) Std.Total.to_isDirected [Std.Total r] : IsDirected α r
+ instance (priority := 100) Std.Total.to_refl (r : α → α → Prop) [Std.Total r] : Std.Refl r
+ instance : @Std.Total (MulArchimedeanOrder M) (· ≤ ·)
+ instance [@Std.Total α (· ≤ ·)] : @Std.Total (Quotient s) (· ≤ ·)
+ instance [DecidableLE α] [DecidableLT α] [@Std.Total α (· ≤ ·)] :
+ instance [IsTrichotomous ι r] [∀ i, Std.Total (s i)] : Std.Total (Lex r s)
+ instance [Std.Total r] [Std.Total s] : Std.Total (Lex r s)
+ instance _root_.WithTop.total_le [LE α] [@Std.Total α (· ≤ ·)] :
+ instance {α} [Encodable α] : Std.Total (Encodable.encode' α ⁻¹'o (· ≤ ·))
+ multiplicative_of_symmetric_of_total
+ multiplicative_of_total
+ not_incompRel_of_total
+ total_left
+ total_right
++ total
++ total_le
++-- le_total_ideal
+-- isTotal
- Colex.isTotal_le
- IsTotal.decide
- IsTotal.directed
- IsTotal.isTrichotomous
- IsTotal.swap
- LE.isTotal
- Lex.isTotal_le
- LowerSet.isTotal_le
- OrderDual.isTotal_le
- Prop.le_isTotal
- UpperSet.isTotal_le
- instIsTotal
- instance (priority := 100) IsTotal.to_isDirected [IsTotal α r] : IsDirected α r
- instance (priority := 100) IsTotal.to_refl (r) [IsTotal α r] : Std.Refl r
- instance : IsTotal (MulArchimedeanOrder M) (· ≤ ·)
- instance [DecidableLE α] [DecidableLT α] [IsTotal α (· ≤ ·)] :
- instance [IsTotal α (· ≤ ·)] : IsTotal (Quotient s) (· ≤ ·)
- instance [IsTotal α r] [IsTotal β s] : IsTotal (α ⊕ β) (Lex r s)
- instance [IsTrichotomous ι r] [∀ i, IsTotal (α i) (s i)] : IsTotal _ (Lex r s)
- instance _root_.WithTop.isTotal_le [LE α] [IsTotal α (· ≤ ·)] : IsTotal (WithTop α) (· ≤ ·)
- instance {α} [Encodable α] : IsTotal _ (Encodable.encode' α ⁻¹'o (· ≤ ·))
- isTotal_left
- isTotal_right
-- isTotal_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Order/Basic.lean Outdated
Comment thread Mathlib/Order/Comparable.lean Outdated
Comment thread Mathlib/Order/Comparable.lean Outdated
Comment thread Mathlib/RingTheory/Valuation/ValuationRing.lean Outdated
Comment thread Mathlib/RingTheory/Valuation/ValuationSubring.lean Outdated
@SnirBroshi SnirBroshi added the t-order Order theory label Jan 11, 2026
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 12, 2026
@SnirBroshi
SnirBroshi requested a review from vihdzp January 13, 2026 03:01
@SnirBroshi SnirBroshi removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 13, 2026
Comment thread Mathlib/Algebra/Group/Basic.lean
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 18, 2026
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 19, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 19, 2026
@SnirBroshi SnirBroshi removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 19, 2026
@SnirBroshi
SnirBroshi requested a review from urkud January 19, 2026 16:37

@jcommelin jcommelin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 20, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jan 20, 2026
@mathlib-bors

mathlib-bors Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Order/Defs/Unbundled): deprecate IsTotal in favor of core's Std.Total [Merged by Bors] - chore(Order/Defs/Unbundled): deprecate IsTotal in favor of core's Std.Total Jan 20, 2026
@mathlib-bors mathlib-bors Bot closed this Jan 20, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants