Skip to content

feat(kits): split LogoutListener from AttributeListener#683

Closed
denischilik wants to merge 2 commits into
workstation/6.0-Releasefrom
feature/remove-attribute-listener
Closed

feat(kits): split LogoutListener from AttributeListener#683
denischilik wants to merge 2 commits into
workstation/6.0-Releasefrom
feature/remove-attribute-listener

Conversation

@denischilik

@denischilik denischilik commented Mar 27, 2026

Copy link
Copy Markdown

Summary

  • Introduces KitIntegration.LogoutListener as a separate contract from the deprecated AttributeListener.
  • KitManagerImpl.logout() invokes logout() only on kits that implement LogoutListener.
  • All embedded kits that previously implemented AttributeListener now explicitly implement LogoutListener as well.
  • AttributeListenerTestKit implements both interfaces for instrumented tests.

@denischilik denischilik requested a review from a team as a code owner March 27, 2026 17:48
@cursor

cursor Bot commented Mar 27, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Behavior changes for logout forwarding: KitManagerImpl.logout() now calls logout() only on kits implementing the new KitIntegration.LogoutListener, so any third-party/sideloaded kit relying on AttributeListener.logout() must be updated or will stop receiving logout callbacks.

Overview
Introduces a dedicated logout contract for kits. KitIntegration.LogoutListener is added and the logout() method is removed from the deprecated AttributeListener.

KitManagerImpl.logout() is updated to invoke logout only for providers implementing LogoutListener, and embedded kits/tests that previously relied on AttributeListener are updated to also implement LogoutListener so they continue receiving logout callbacks.

Written by Cursor Bugbot for commit ed12758. This will update automatically on new commits. Configure here.

@denischilik denischilik changed the base branch from main to workstation/6.0-Release March 27, 2026 17:50
Introduce KitIntegration.LogoutListener for logout handling; AttributeListener
no longer extends it. KitManagerImpl calls logout() on LogoutListener only.
Embedded kits that implement AttributeListener now explicitly implement
LogoutListener; AttributeListenerTestKit updated accordingly.
@denischilik denischilik force-pushed the feature/remove-attribute-listener branch from 9f8dc36 to ed12758 Compare March 27, 2026 17:55
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@denischilik denischilik deleted the feature/remove-attribute-listener branch March 27, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant