Implement VSETATTR command for vector set attribute updates#1531
Closed
Copilot wants to merge 1 commit intotiagonapoli/add-vsetattrfrom
Closed
Implement VSETATTR command for vector set attribute updates#1531Copilot wants to merge 1 commit intotiagonapoli/add-vsetattrfrom
Copilot wants to merge 1 commit intotiagonapoli/add-vsetattrfrom
Conversation
Copilot
AI
changed the title
[WIP] Implement VSETATTR functionality
Implement VSETATTR command for vector set attribute updates
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
VSETATTRcommand to update attributes on existing vector elements without modifying the vector data itself.Implementation Details
VectorSetUpdateAttributes()inVectorStoreOps.csthat acquires read lock on the vector index and callsVectorManager.TryUpdateElementAttributes()NativeDiskANNMethods.set_attribute()to update attributes in the DiskANN indexReplicateVectorUpdateAttributes()on successful updatesInitialUpdater,InPlaceUpdater, andCopyUpdaterfor replication path (assertions ensure only replication triggers these paths)Usage
Architecture Note
VSETATTRandVADDuse separate native methods for attribute writes:VADD→insert()- writes attributes during element insertionVSETATTR→set_attribute()- updates attributes on existing elementsNo shared attribute write path exists between the commands.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.