Use a separate node for the srv IK client#3704
Open
stephanie-eng wants to merge 2 commits intomoveit:mainfrom
Open
Use a separate node for the srv IK client#3704stephanie-eng wants to merge 2 commits intomoveit:mainfrom
stephanie-eng wants to merge 2 commits intomoveit:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3704 +/- ##
==========================================
+ Coverage 46.22% 46.24% +0.03%
==========================================
Files 726 726
Lines 59503 59506 +3
Branches 7623 7623
==========================================
+ Hits 27499 27514 +15
+ Misses 31836 31826 -10
+ Partials 168 166 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The srv_kinematics_plugin doesn't seem to play that well with RViz.
It uses the same node for the ik client that RViz does, so spinning until future complete generates this kind of error:
We probably don't want to spin until future is complete. We also don't want to block RViz either. So let's just make a new node and use that.
Also calm down a very spammy RCLCPP_INFO.
Checklist