Skip to content

Use a separate node for the srv IK client#3704

Open
stephanie-eng wants to merge 2 commits intomoveit:mainfrom
stephanie-eng:seng/srv-ik-node2
Open

Use a separate node for the srv IK client#3704
stephanie-eng wants to merge 2 commits intomoveit:mainfrom
stephanie-eng:seng/srv-ik-node2

Conversation

@stephanie-eng
Copy link
Contributor

Description

The srv_kinematics_plugin doesn't seem to play that well with RViz.
It uses the same node for the ik client that RViz does, so spinning until future complete generates this kind of error:

Exception caught while handling end-effector update: Node '/rviz' has already been added to an executor.​

We probably don't want to spin until future is complete. We also don't want to block RViz either. So let's just make a new node and use that.

Also calm down a very spammy RCLCPP_INFO.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.24%. Comparing base (c154f94) to head (1285c4f).

Files with missing lines Patch % Lines
...rv_kinematics_plugin/src/srv_kinematics_plugin.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3704      +/-   ##
==========================================
+ Coverage   46.22%   46.24%   +0.03%     
==========================================
  Files         726      726              
  Lines       59503    59506       +3     
  Branches     7623     7623              
==========================================
+ Hits        27499    27514      +15     
+ Misses      31836    31826      -10     
+ Partials      168      166       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant