Skip to content

Do not fail Rolling jobs on deprecations#3706

Merged
nbbrooks merged 1 commit intomainfrom
pr-do-not-fail-rolling-ci-on-deprecations
Mar 16, 2026
Merged

Do not fail Rolling jobs on deprecations#3706
nbbrooks merged 1 commit intomainfrom
pr-do-not-fail-rolling-ci-on-deprecations

Conversation

@nbbrooks
Copy link
Contributor

Description

Unfortunately, the timing+pace of rolling deprecations is outpacing the ability to address them with our current set of active maintainers and contributors. Originally we configured CI jobs to fail on deprecations to force us to fix them, but at this point, often when we go to fix them, there are several simultaneous deprecations from various upstream sources which requires one of the following to happen

  • A mega PR (examples Fix deprecations in image_common and tf2_ros #3567 and Qt6 compile fix #3493) that addresses all deprecations simultaneous
  • A targeted PR for a single deprecation but large reviewer burden to locally build the PR against each supported distro since the CI jobs short circuit (and an override of CI to merge the PR)
  • Fingers crossed merge with CI failing rather than a large review burden (and an override of CI)

This is not sustainable anymore (and promotes huge PRs that are tough to review), so what I'm doing in this PR is:

  • Add '-Wno-error=deprecated-declarations' to mandatory Rolling CI jobs.
  • Add new, currently optional CI Rolling job that does fail on deprecations

Depending on the state of upstream deprecations maintainers can change the state of this new, currently optional CI Rolling job that does fail on deprecations. But for now I would like to unblock community contributions while we address the current set of deprecations.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Add new optional CI Rolling job that does fail on deprecations
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (848c062) to head (72c800b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #3706       +/-   ##
==========================================
- Coverage   46.24%   0.00%   -46.23%     
==========================================
  Files         726     539      -187     
  Lines       59483   47592    -11891     
  Branches     7624    6085     -1539     
==========================================
- Hits        27504       0    -27504     
- Misses      31813   47592    +15779     
+ Partials      166       0      -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nbbrooks
Copy link
Contributor Author

Force merging this - the required Rolling jobs are failing due to lack of Qt6 support. The new optional rolling deprecated job is failing as expected due to deprecations.

@nbbrooks nbbrooks merged commit f1135a4 into main Mar 16, 2026
6 of 12 checks passed
@nbbrooks nbbrooks deleted the pr-do-not-fail-rolling-ci-on-deprecations branch March 16, 2026 14:51
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants