feat: pass through auth.denyRedirect to the NebariApp spec - #44
Closed
tylerpotts wants to merge 1 commit into
Closed
feat: pass through auth.denyRedirect to the NebariApp spec#44tylerpotts wants to merge 1 commit into
tylerpotts wants to merge 1 commit into
Conversation
Contributor
Author
|
this isn't needed right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart renders NebariApp.spec.auth but has no way to set denyRedirect, the nebari-operator field that returns 401 instead of an OIDC redirect for matching requests.
Without it, gateway-enforced OIDC (enforceAtGateway, nebi's default posture: no in-app SSO proxy) is vulnerable to the PKCE state-cookie race the operator API documents: on page load the browser fires the document request plus site.webmanifest/favicon/asset requests in parallel, each gets its own 302-to-Keycloak with a fresh state cookie, they overwrite each other, and the document's callback fails state validation and restarts the flow. On a deployment behind a private CA (Concepts-NREC) this presents as an infinite login redirect loop on nebi's UI: the browser console shows the webmanifest request captured mid-OAuth-flow (its URL encoded in the state parameter) while Keycloak logs no client errors, since codes are issued fine and rejected client-side by Envoy.
Changes:
Verified with helm template: the documented example renders into the NebariApp spec correctly, and default values render identically to 0.1.2.