Skip to content

feat: pass through auth.denyRedirect to the NebariApp spec #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tylerpotts wants to merge 1 commit into from
Closed

feat: pass through auth.denyRedirect to the NebariApp spec #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: nebari-nebi-pack
description: A Helm chart for deploying Nebi (environment management platform) on Nebari
type: application
version: 0.1.2
version: 0.1.3
appVersion: "0.13"
4 changes: 4 additions & 0 deletions templates/nebariapp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ spec:
tokenExchange:
enabled: {{ .enabled | default false }}
{{- end }}
{{- with .denyRedirect }}
denyRedirect:
{{- toYaml . | nindent 6 }}
{{- end }}
{{- end }}
{{- with .Values.nebariapp.landingPage }}
landingPage:
Expand Down
11 changes: 11 additions & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,17 @@ nebariapp:
# token for a Nebi-audience token in Keycloak. Required by the jhub-apps
# environment selector and Nebi auto-auth.
enabled: true
# denyRedirect passes through to NebariApp.spec.auth.denyRedirect: header
# match rules for requests that should get a 401 instead of an OIDC
# redirect. Without it, non-navigation requests fired in parallel on page
# load (site.webmanifest, favicons, XHR) each start their own OAuth flow
# and overwrite each other's state cookies, which can lock browsers into
# an infinite auth redirect loop. Recommended:
# denyRedirect:
# - name: Sec-Fetch-Dest
# type: RegularExpression
# value: ^(manifest|empty|image|font|style|script)$
denyRedirect: []
# landingPage controls whether and how this service appears on the Nebari landing page
# portal (served by nebari-landing / nebari-webapi).
landingPage:
Expand Down
Loading