feat: access token & enhance endpoints (/login, /userinfo, /logout)#68
Closed
shawnhankim wants to merge 1 commit intonginxinc:mainfrom
Closed
feat: access token & enhance endpoints (/login, /userinfo, /logout)#68shawnhankim wants to merge 1 commit intonginxinc:mainfrom
shawnhankim wants to merge 1 commit intonginxinc:mainfrom
Conversation
**Issue Item:** - nginxinc#62 **Description:** **1. access token** - Enhance the NJS Code to capture the `access_token` sent by the IdP. - Store the `access_token` in the k/v store as same as we store `id_token` and `refresh_token` **2. new endpoints** - Add `/userinfo` endpoint: - Add a map variable of `$oidc_userinfo_endpoint` as same as authz and token endpoints here (`openid_connect_configuration.conf`) . - Expose `/userinfo` endpoint here(`openid_connect.server_conf`) in a location block of NGINX Plus to interact with IdP's `userinfo_endpoint` which is defined in the endpoint of`well-known/openid-configuration`. - The nginx location block should proxy to the IdP’s `userinfo_endpoint` by adding `access_token` as a bearer token. ``` Authorization : Bearer <access_token> ``` - The response coming from IdP should be returned back to the caller as it is. - Expose `/login` endpoint: - Expose the `/login` endpoint as a location block here (`openid_connect.server_conf`) - Proxy it to the IdP's `authorization_endpoint` configured in the map variable of `$oidc_authz_endpoint` in (`openid_connect_configuration.conf`). - This would outsource the login function to IdP as its configured. - Enhance `/logout` endpoint: - Add a map variable of `$oidc_end_session_endpoint` as same as authz and token endpoints here (`openid_connect_configuration.conf`) . - Proxy it to the IdP's `end_session_endpoint` to finish the session by IdP. - Enhance `/_logout` endpoint: - Enhance `/_logout` endpoint which is a callback from IdP as a location block here (`openid_connect.server_conf`) to handle the following sequences. - 1. Redirected by IdP when IdP successfully finished the session. - 2. NGINX Plus: Clear session cookies. - 3. NGINX Plus: Redirect to either the landing page or the custom logout page by calling **3. add endpoints in `configure.sh`** - IdP's userinfo endpoint - IdP's end session endpoint **Compatibility:** - This PR does not block the existing customers as it just adds endpoints and features.
Contributor
Author
|
This was referenced Dec 22, 2022
Merged
Contributor
Author
|
I am closing this PR as it is divided into the following PRs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Item:
Description:
1. access token
access_tokensent by the IdP.access_tokenin the k/v store as same as we storeid_tokenandrefresh_token2. new endpoints
Add
/userinfoendpoint:$oidc_userinfo_endpointas same as authz and token endpoints here (openid_connect_configuration.conf) ./userinfoendpoint here(openid_connect.server_conf) in a location block of NGINX Plus to interact with IdP'suserinfo_endpointwhich is defined in the endpoint ofwell-known/openid-configuration.userinfo_endpointby addingaccess_tokenas a bearer token.Expose
/loginendpoint:/loginendpoint as a location block here (openid_connect.server_conf)authorization_endpointconfigured in the map variable of$oidc_authz_endpointin (openid_connect_configuration.conf).Enhance
/logoutendpoint:$oidc_end_session_endpointas same as authz and token endpoints here (openid_connect_configuration.conf) .end_session_endpointto finish the session by IdP.Enhance
/_logoutendpoint:/_logoutendpoint which is a callback from IdP as a location block here (openid_connect.server_conf) to handle the following sequences.3. add endpoints in
configure.shCompatibility: