Conversation
|
route443
left a comment
There was a problem hiding this comment.
Hi Shawn. Thank you for your contribution to our nginx oidc project.
As I said in previous PRs, we are not using Conventional Commits for this project. So I wouldn't use this approach unnecessarily. Please change the commit name.
df76cdd to
1c0f658
Compare
Hi Ivan! Thank you so much for your time to review the PR in detail. I have addressed your comments as well as the new commit name. Please let me know if there is anything need to be changed. Happy New Year! |
df5d840 to
7817f3b
Compare
7817f3b to
996a7da
Compare
996a7da to
916edd2
Compare
shawnhankim
left a comment
There was a problem hiding this comment.
Thanks @route443 for your review. Revised them!
Issue:
Description:
access_tokenin the NJS code.access_tokenin the key/value store as same as the NGINX RP storesid_tokenandrefresh_token.