add windows build #785

mcarbonneaux · 2025-12-19T11:28:44Z

this pull request add windows build

…e-747 pins kafka to 3.5.2 for containerlab version of single-instance kafka-output example

Simplify interfaces

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.41.0 to 0.42.0. - [Commits](golang/crypto@v0.41.0...v0.42.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.42.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…es/golang.org/x/crypto-0.42.0 Bump golang.org/x/crypto from 0.41.0 to 0.42.0

…re the next path element.

handle `[null]` and `null` when format is `event`

add missing processor name to proc list

fail xpath parsing when there are trailing chars after a key and before the next path element

bump api pkg go version and main pkg dependencies

- Handle leading slash for flat format when origin is not included in prefix or prefix is non-existant

…ding-input-jetstream-setting feat: capability for jetstream input to set MaxAckPending

…D is documented incorrectly

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 8 to 9. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v8...v9) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-version: '9' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

fix openconfig#770 The API path to patch subscriptions for a target ID is wrong

fix event_group_by not handling delete events

…ctions/golangci/golangci-lint-action-9 Bump golangci/golangci-lint-action from 8 to 9

Fix leading slash handling for flat format

…es/golang.org/x/crypto-0.45.0 Bump golang.org/x/crypto from 0.43.0 to 0.45.0

google-cla · 2025-12-19T11:28:48Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

karimra · 2025-12-24T17:30:21Z

Windows builds were remove some time ago: karimra/gnmic#196
Any reason using WSL is not an option?
There are a few dependencies that don't work that well on Windows (go-prompt for example), that's why windows builds were removed.

mcarbonneaux · 2025-12-29T21:51:08Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

it's overkill to use wsl for that... why not using native windows ?!
the advantage of native windows it's can be used in powershell context to....

mcarbonneaux · 2025-12-30T14:15:20Z

go-prompt work fine in jetbrains terminal, but not fine on windows terminal... but work through msys2 pty posix emullation but is not perfect...
and can be disabled on not used on windows... or use alternative that are compatible with windows...

on with msys (had some problem with windows terminal size calculation) on windows terminal:

mcarbonneaux · 2025-12-30T14:21:01Z

for windows we can use https://github.com/chzyer/readline in place of go-prompt.
it's possible to detect the platform an choose go-prompt of readline...

and go-prompt last commit as 4 years back, 28 pull request stale, multiple fork.... and readline last commit as 6 months only....
the more updated fork is https://github.com/elk-language/go-prompt....

mcarbonneaux · 2025-12-30T16:53:55Z

i've migrated to https://github.com/elk-language/go-prompt and is working fine on windows terminal !!!!

…/go-prompt

karimra · 2026-01-10T17:45:59Z

Fair point on go-prompt being abandoned, but do people really use windows to run gNMI ? How niche is it ?
Adding back windows builds means I will have to start supporting and fixing windows specific issues.

karimra · 2026-01-10T17:46:29Z

.github/workflows/release.yml

+        if: runner.os != 'Windows'
+        env:
+          CGO_ENABLED: 0
+      - run: bash ./tests/run_tests.sh


this wouldn't work right ?

windows runner are build with bash but you need to call explicitly to use it.

…sage: Deprecated, use `fail_level` instead.

mcarbonneaux · 2026-01-12T10:24:54Z

test run ok : https://github.com/mcarbonneaux/gnmic/actions/runs/20915617555
but macos and windows staticcheck fail, and i think is reviewdog/action-staticcheck but on this plateform (they download static binary of another plateform...), i've removed because they dont need to be executed on any architecture but on code, the linux one is suffisant.

karimra and others added 27 commits September 28, 2025 09:53

Merge pull request openconfig#748 from hyposcaler-bot/hyposcaler/issu…

8cea597

…e-747 pins kafka to 3.5.2 for containerlab version of single-instance kafka-output example

Merge pull request openconfig#746 from nokia/refactor-interfaces

052515d

Simplify interfaces

Merge pull request openconfig#734 from openconfig/dependabot/go_modul…

4fed1b2

…es/golang.org/x/crypto-0.42.0 Bump golang.org/x/crypto from 0.41.0 to 0.42.0

handle [null] and null when format is event

1a8ee6f

add missing processor name to proc list

b6933bc

fail xpath parsing when there are trailing chars after a key and befo…

7a1995e

…re the next path element.

Merge pull request openconfig#754 from openconfig/fix753

07786fa

handle `[null]` and `null` when format is `event`

Merge pull request openconfig#755 from openconfig/reorg-proc-list

0314bda

add missing processor name to proc list

Merge pull request openconfig#756 from openconfig/fix751

938d926

fail xpath parsing when there are trailing chars after a key and before the next path element

bump api pkg go version and main pkg dependencies

5c8542a

Merge pull request openconfig#757 from openconfig/bump-api-deps

a387236

bump api pkg go version and main pkg dependencies

feat: capability for jetstream input to set MaxAckPending

65d4abe

Fix leading slash handling for flat format

1e57a5f

- Handle leading slash for flat format when origin is not included in prefix or prefix is non-existant

Merge pull request openconfig#758 from marco-minervino/feat-maxackpen…

e6f5eef

…ding-input-jetstream-setting feat: capability for jetstream input to set MaxAckPending

fix event_group_by not handling delete events

0514e8c

fix openconfig#770 The API path to patch subscriptions for a target I…

d6839c2

…D is documented incorrectly

Address karima comments

0686dee

Handle prefix without origin

add67c2

Merge pull request openconfig#771 from ashvanth48t/main

fc37d57

fix openconfig#770 The API path to patch subscriptions for a target ID is wrong

Merge pull request openconfig#769 from alkshmir/main

8d3249f

fix event_group_by not handling delete events

Merge pull request openconfig#773 from openconfig/dependabot/github_a…

2db8319

…ctions/golangci/golangci-lint-action-9 Bump golangci/golangci-lint-action from 8 to 9

Merge pull request openconfig#760 from earies/flat-root

1172391

Fix leading slash handling for flat format

Merge pull request openconfig#776 from openconfig/dependabot/go_modul…

055b727

…es/golang.org/x/crypto-0.45.0 Bump golang.org/x/crypto from 0.43.0 to 0.45.0

add windows build

1f85795

change github.com/c-bata/go-prompt to https://github.com/elk-language…

55003e6

…/go-prompt

karimra reviewed Jan 10, 2026

View reviewed changes

mcarbonneaux added 5 commits January 12, 2026 10:34

add gnmic.exe to .gitignore

21b7995

ignore arm arch for windows

d28cf36

add cache and fail fast to debug windows test (without macos fail)

d8c5d6f

to remove Warning: Input 'fail_on_error' has been deprecated with mes…

691114a

…sage: Deprecated, use `fail_level` instead.

try to fix staticcheck fail on macos and windows by updating reviewdog

2dad991

mcarbonneaux force-pushed the main branch from 5a795bd to 2dad991 Compare January 12, 2026 09:58

mcarbonneaux added 2 commits January 12, 2026 11:01

try to use version in place on hash to try to fix

ae82099

remove staticcheck on windows/macos only one is needed

b3ec6f3

mcarbonneaux force-pushed the main branch from 45502fd to b3ec6f3 Compare January 12, 2026 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add windows build #785

add windows build #785

Uh oh!

mcarbonneaux commented Dec 19, 2025

Uh oh!

google-cla bot commented Dec 19, 2025

Uh oh!

karimra commented Dec 24, 2025

Uh oh!

mcarbonneaux commented Dec 29, 2025

Uh oh!

mcarbonneaux commented Dec 30, 2025 •

edited

Loading

Uh oh!

mcarbonneaux commented Dec 30, 2025 •

edited

Loading

Uh oh!

mcarbonneaux commented Dec 30, 2025 •

edited

Loading

Uh oh!

karimra commented Jan 10, 2026

Uh oh!

karimra Jan 10, 2026

Uh oh!

mcarbonneaux Jan 12, 2026

Uh oh!

mcarbonneaux commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

add windows build #785

Are you sure you want to change the base?

add windows build #785

Uh oh!

Conversation

mcarbonneaux commented Dec 19, 2025

Uh oh!

google-cla bot commented Dec 19, 2025

Uh oh!

karimra commented Dec 24, 2025

Uh oh!

mcarbonneaux commented Dec 29, 2025

Uh oh!

mcarbonneaux commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcarbonneaux commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcarbonneaux commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karimra commented Jan 10, 2026

Uh oh!

karimra Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

mcarbonneaux Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

mcarbonneaux commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mcarbonneaux commented Dec 30, 2025 •

edited

Loading

mcarbonneaux commented Dec 30, 2025 •

edited

Loading

mcarbonneaux commented Dec 30, 2025 •

edited

Loading