add windows build

.github/workflows/lint.yml

@@ -28,7 +28,7 @@ jobs:
         with:
           go-version: ${{ env.GOVER }}
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v8
+        uses: golangci/golangci-lint-action@v9
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
           version: v1.46

.github/workflows/release.yml

@@ -13,18 +13,26 @@ on:
     tags:
       - v*
 env:
-  GOVER: 1.24.7
-  GORELEASER_VER: v1.19.2
+  GOVER: 1.24.x
+  GORELEASER_VER: latest
 
 jobs:
   test:
-    runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        os: [ubuntu-22.04, macos-latest, windows-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v5
       - uses: actions/setup-go@v6
         with:
           go-version: ${{ env.GOVER }}
       - run: ./tests/run_tests.sh
+        if: runner.os != 'Windows'
+        env:
+          CGO_ENABLED: 0
+      - run: bash ./tests/run_tests.sh
+        if: runner.os == 'Windows'
         env:
           CGO_ENABLED: 0
 

.github/workflows/test.yml

@@ -16,26 +16,37 @@ on:
       - "main"
       - "!releases/**"
 env:
-  GOVER: 1.24.7
+  GOVER: 1.24.x
 
 jobs:
   test:
-    runs-on: ubuntu-22.04
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-22.04, macos-latest, windows-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v5
       - uses: actions/setup-go@v6
         with:
           go-version: ${{ env.GOVER }}
+          cache: true
       - run: ./tests/run_tests.sh
+        if: runner.os != 'Windows'
+        env:
+          CGO_ENABLED: 0
+      - run: bash ./tests/run_tests.sh
+        if: runner.os == 'Windows'
         env:
           CGO_ENABLED: 0
       # run staticcheck
-      - uses: reviewdog/action-staticcheck@73cfd0daa6fdbba9a858dcb0f62844012fa8317d
+      - uses: reviewdog/[email protected]
+        if: runner.os == 'Linux'
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           # Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review].
           reporter: github-pr-review
           # Report all results.
           filter_mode: nofilter
           # Exit with 1 when it find at least one finding.
-          fail_on_error: true
+          fail_level: error

.gitignore

@@ -6,6 +6,7 @@ builds/
 dist
 *.log
 gnmic
+gnmic.exe
 *.tmp
 *.work*
 .idea

.goreleaser.yml

@@ -15,11 +15,15 @@ builds:
     goos:
       - linux
       - darwin
+      - windows
     goarch:
       - amd64
       - "386"
       - arm
       - arm64
+    ignore:
+      - goos: windows
+        goarch: arm
 dockers:
   - goos: linux
     goarch: amd64

docs/user_guide/api/configuration.md

@@ -248,6 +248,44 @@ Returns an empty body
     ```json
     ```
 
+### `PATCH /api/v1/config/targets/{id}/subscriptions`
+
+Updates existing subscriptions for the target ID
+
+Returns an empty body if successful.
+
+=== "Request"
+    ```bash
+    curl --request PATCH gnmic-api-address:port/api/v1/config/targets/192.168.1.131:57400/subscriptions -d '{"subscriptions": ["sub1", "sub2"]}'
+    ```
+=== "200 OK"
+    ```json
+    ```
+=== "404 Not found"
+    ```json
+    {
+        "errors": [
+            "target $target not found"
+        ]
+    }
+    ```
+=== "400 Bad Request"
+    ```json
+    {
+        "errors": [
+            "subscription $subscription does not exist"
+        ]
+    }
+    ```
+=== "500 Internal Server Error"
+    ```json
+    {
+        "errors": [
+            "Error Text"
+        ]
+    }
+    ```
+
 ## /api/v1/config/subscriptions
 
 ### `GET /api/v1/config/subscriptions`

docs/user_guide/api/targets.md

@@ -194,41 +194,4 @@ Returns an empty body if successful.
         ]
     }
     ```
-
-## `PATCH /api/v1/targets/{id}/subscriptions`
-
-Updates existing subscriptions for the target ID
-
-Returns an empty body if successful.
 
-=== "Request"
-    ```bash
-    curl --request PATCH gnmic-api-address:port/api/v1/targets/192.168.1.131:57400/subscriptions -d '{"subscriptions": ["sub1", "sub2"]}'
-    ```
-=== "200 OK"
-    ```json
-    ```
-=== "404 Not found"
-    ```json
-    {
-        "errors": [
-            "target $target not found"
-        ]
-    }
-    ```
-=== "400 Bad Request"
-    ```json
-    {
-        "errors": [
-            "subscription $subscription does not exist"
-        ]
-    }
-    ```
-=== "500 Internal Server Error"
-    ```json
-    {
-        "errors": [
-            "Error Text"
-        ]
-    }
-    ```

docs/user_guide/inputs/jetstream_input.md

@@ -64,6 +64,10 @@ inputs:
     # default: 500
     fetch-batch-size: 200
 
+    # integer, maximum number of allowed pending ack on the stream
+    # default: 1000
+    max-ack-pending: 5000
+
     # optional list of output names this input writes to
     # outputs must be configured at the root `outputs:` section
     outputs:

examples/deployments/1.single-instance/1.nats-output/containerlab/gnmic.yaml

@@ -16,7 +16,7 @@ loader:
   type: docker
   filters:
     - containers:
-      - label=clab-node-kind: srl
+      - label=clab-node-kind: nokia_srlinux
         label=containerlab: lab11
 
 subscriptions:

examples/deployments/1.single-instance/11.kafka-kraft-output/containerlab/gnmic.yaml

@@ -0,0 +1,36 @@
+# © 2022 Nokia.
+#
+# This code is a Contribution to the gNMIc project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0.
+# No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose.
+# This code is provided on an “as is” basis without any warranties of any kind.
+#
+# SPDX-License-Identifier: Apache-2.0
+
+username: admin
+password: NokiaSrl1!
+skip-verify: true
+encoding: json_ietf
+log: true
+
+# docker target loader
+loader:
+  type: docker
+  filters:
+    - containers:
+      - label=clab-node-kind: nokia_srlinux
+        label=containerlab: lab12
+
+subscriptions:
+  # Add subscriptions configuration here
+  # e.g:
+  sub1:
+    paths:
+      - /interface/statistics
+    stream-mode: sample
+    sample-interval: 10s
+
+outputs:
+  kafka-output:
+    type: kafka
+    address: clab-lab12-kafka-server:9092
+    topic: telemetry

examples/deployments/1.single-instance/11.kafka-kraft-output/containerlab/kafka.clab.yaml

@@ -0,0 +1,62 @@
+# © 2022 Nokia.
+#
+# This code is a Contribution to the gNMIc project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0.
+# No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose.
+# This code is provided on an “as is” basis without any warranties of any kind.
+#
+# SPDX-License-Identifier: Apache-2.0
+
+name: lab12
+
+topology:
+  defaults:
+    kind: nokia_srlinux
+
+  kinds:
+    nokia_srlinux:
+      image: ghcr.io/nokia/srlinux
+
+  nodes:
+    spine1:
+    spine2:
+    leaf1:
+    leaf2:
+    leaf3:
+    leaf4:
+
+    gnmic:
+      kind: linux
+      image: ghcr.io/openconfig/gnmic:latest
+      binds:
+        - ./gnmic.yaml:/app/gnmic.yaml:ro
+        - /var/run/docker.sock:/var/run/docker.sock
+      cmd: '--config /app/gnmic.yaml --log subscribe'
+
+    kafka-server:
+      kind: linux
+      image: bitnami/kafka:latest
+      ports:
+        - 9092:9092
+        - 9093:9093
+      env:
+        KAFKA_ENABLE_KRAFT: yes
+        ALLOW_PLAINTEXT_LISTENER: yes
+        KAFKA_CFG_NODE_ID: 0
+        KAFKA_CFG_PROCESS_ROLES: broker,controller
+        KAFKA_CFG_CONTROLLER_LISTENER_NAMES: CONTROLLER
+        KAFKA_CFG_LISTENERS: PLAINTEXT://:9092,CONTROLLER://:9093
+        KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP: CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT
+        KAFKA_CFG_ADVERTISED_LISTENERS: PLAINTEXT://clab-lab12-kafka-server:9092
+        KAFKA_CFG_CONTROLLER_QUORUM_VOTERS: 0@clab-lab12-kafka-server:9093
+
+  links:
+    # spine1 links
+    - endpoints: ["spine1:e1-1", "leaf1:e1-1"]
+    - endpoints: ["spine1:e1-2", "leaf2:e1-1"]
+    - endpoints: ["spine1:e1-3", "leaf3:e1-1"]
+    - endpoints: ["spine1:e1-4", "leaf4:e1-1"]
+    # spine2 links
+    - endpoints: ["spine2:e1-1", "leaf1:e1-2"]
+    - endpoints: ["spine2:e1-2", "leaf2:e1-2"]
+    - endpoints: ["spine2:e1-3", "leaf3:e1-2"]
+    - endpoints: ["spine2:e1-4", "leaf4:e1-2"]

examples/deployments/1.single-instance/2.kafka-output/containerlab/gnmic.yaml

@@ -17,7 +17,7 @@ loader:
   type: docker
   filters:
     - containers:
-      - label=clab-node-kind: srl
+      - label=clab-node-kind: nokia_srlinux
         label=containerlab: lab12
 
 subscriptions:

examples/deployments/1.single-instance/2.kafka-output/containerlab/kafka.clab.yaml

@@ -34,7 +34,7 @@ topology:
 
     kafka-server:
       kind: linux
-      image: bitnami/kafka:latest
+      image: bitnami/kafka:3.5.2
       ports:
         - 9092:9092
         - 9000:9000
@@ -62,4 +62,4 @@ topology:
     - endpoints: ["spine2:e1-1", "leaf1:e1-2"]
     - endpoints: ["spine2:e1-2", "leaf2:e1-2"]
     - endpoints: ["spine2:e1-3", "leaf3:e1-2"]
-    - endpoints: ["spine2:e1-4", "leaf4:e1-2"]
+    - endpoints: ["spine2:e1-4", "leaf4:e1-2"]

examples/deployments/1.single-instance/3.influxdb-output/containerlab/gnmic.yaml

@@ -16,7 +16,7 @@ loader:
   type: docker
   filters:
     - containers:
-      - label=clab-node-kind: srl
+      - label=clab-node-kind: nokia_srlinux
         label=containerlab: lab13
 
 subscriptions:

examples/deployments/1.single-instance/4.prometheus-output/containerlab/gnmic.yaml

@@ -15,7 +15,7 @@ loader:
   type: docker
   filters:
     - containers:
-      - label=clab-node-kind: srl
+      - label=clab-node-kind: nokia_srlinux
         label=containerlab: lab14
 
 subscriptions:

examples/deployments/1.single-instance/4.prometheus-output/containerlab/prometheus.clab.yaml

@@ -13,10 +13,10 @@ mgmt:
 
 topology:
   defaults:
-    kind: srl
+    kind: nokia_srlinux
 
   kinds:
-    srl:
+    nokia_srlinux:
       image: ghcr.io/nokia/srlinux
 
   nodes:

examples/deployments/1.single-instance/6.prometheus-write-output/containerlab/gnmic.yaml

@@ -16,7 +16,7 @@ loader:
   type: docker
   filters:
     - containers:
-      - label=clab-node-kind: srl
+      - label=clab-node-kind: nokia_srlinux
         label=containerlab: lab16
 
 subscriptions: