Skip to content

Comments

Add PR template#161

Open
tmeisel wants to merge 3 commits intomainfrom
chore/ace-3-pr-template
Open

Add PR template#161
tmeisel wants to merge 3 commits intomainfrom
chore/ace-3-pr-template

Conversation

@tmeisel
Copy link
Contributor

@tmeisel tmeisel commented Feb 16, 2026

Issue

Description

This PR adds a pull request template to .github/PULL_REQUEST_TEMPLATE/pull_request_template.md. This PR follows the suggested template.

Checklist

  • PR required dependency updates
  • I've added tests that cover the changes
  • I've updated the documentation to reflect the new behavior

Additional Authors

none

@tmeisel tmeisel self-assigned this Feb 16, 2026
@github-actions github-actions bot added the chore A routine task or common potentially re-occurring task label Feb 16, 2026
@@ -0,0 +1,19 @@
## Issue

- [ ] [Solutions Arsenal xx](https://github.com/opendefensecloud/solution-arsenal/issues/xx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solutions Arsenal -> Solution Arsenal?

Maybe just the link is fine as well, as github renders it properly anyway, e.g. #155

Comment on lines +1 to +6
## Issue

- [ ] [Solution Arsenal xx](https://github.com/opendefensecloud/solution-arsenal/issues/xx)
- [ ] Internal
- [ ] Chore
- [ ] Hotfix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to simplify this and every PR leads with:
Closes {LINK TO ISSUE} <!-- If applicable to the PR -->

<!-- Add a description of what and how you are trying to solve a problem or add a feature -->

## Checklist
- [ ] PR required dependency updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also ran linters and made sure code is properly formated as addtional checklist steps?

- [ ] PR required dependency updates
- [ ] I've added tests that cover the changes
- [ ] I've updated the documentation to reflect the new behavior

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add a section asking which additional tests are requested to be run by the PR with a checklist, following our labels, e.g. "ok-to-helm", "ok-to-image".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A routine task or common potentially re-occurring task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants