Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
## Issue

- [ ] [Solution Arsenal xx](https://github.com/opendefensecloud/solution-arsenal/issues/xx)
- [ ] Internal
- [ ] Chore
- [ ] Hotfix
Comment on lines +1 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to simplify this and every PR leads with:
Closes {LINK TO ISSUE} <!-- If applicable to the PR -->


## Description

<!-- Add a description of what and how you are trying to solve a problem or add a feature -->

## Checklist
- [ ] PR required dependency updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also ran linters and made sure code is properly formated as addtional checklist steps?

- [ ] I've added tests that cover the changes
- [ ] I've updated the documentation to reflect the new behavior

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add a section asking which additional tests are requested to be run by the PR with a checklist, following our labels, e.g. "ok-to-helm", "ok-to-image".

## Additional Authors

<!-- Mention additional authors or teams here using @username syntax -->
Loading