-
Notifications
You must be signed in to change notification settings - Fork 0
Add PR template #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add PR template #161
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ## Issue | ||
|
|
||
| - [ ] [Solution Arsenal xx](https://github.com/opendefensecloud/solution-arsenal/issues/xx) | ||
| - [ ] Internal | ||
| - [ ] Chore | ||
| - [ ] Hotfix | ||
|
|
||
| ## Description | ||
|
|
||
| <!-- Add a description of what and how you are trying to solve a problem or add a feature --> | ||
|
|
||
| ## Checklist | ||
| - [ ] PR required dependency updates | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe also ran linters and made sure code is properly formated as addtional checklist steps? |
||
| - [ ] I've added tests that cover the changes | ||
| - [ ] I've updated the documentation to reflect the new behavior | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could also add a section asking which additional tests are requested to be run by the PR with a checklist, following our labels, e.g. "ok-to-helm", "ok-to-image". |
||
| ## Additional Authors | ||
|
|
||
| <!-- Mention additional authors or teams here using @username syntax --> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose to simplify this and every PR leads with:
Closes {LINK TO ISSUE} <!-- If applicable to the PR -->