[OCISDEV-822] preserve upload bin on Finalize failure#577
Merged
Conversation
When WriteBlob fails during synchronous finalization, Cleanup was called with cleanBin=true unconditionally, permanently deleting the bin file from uploads/ even though the blob never reached blobs/. This makes the blob unrecoverable, even via move-stuck-upload-blobs. Fix: only clean the bin file when Finalize succeeds (err == nil). Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
kobergj
changed the title
mklos-kw
approved these changes
Apr 23, 2026
2403905
approved these changes
Apr 23, 2026
kobergj
deleted the
fix/OCISDEV-822-preserve-upload-bin-on-finalize-failure
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalizefails during synchronous upload finalization,Cleanupwas called withcleanBin=trueunconditionally, permanently deleting the bin file fromuploads/even though the blob never reachedblobs/move-stuck-upload-blobs— causing e.g. missingreceived.jsonblobs in the jsoncs3 share manager metadata spaceerr == nilascleanBinso the bin is only removed on successTest plan
WriteBlobfailure during synchronous finalization (e.g. cross-device rename on NFS); confirm bin file is preserved inuploads/move-stuck-upload-blobsafter a failed finalization; confirm the bin is now recoverable🤖 Generated with Claude Code