Skip to content

[OCISDEV-822] preserve upload bin on Finalize failure #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kobergj merged 1 commit into from
Apr 23, 2026
Merged

[OCISDEV-822] preserve upload bin on Finalize failure #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions changelog/unreleased/fix-preserve-upload-bin-on-finalize-failure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Bugfix: Preserve upload bin when synchronous Finalize fails

When a synchronous upload finalization (e.g. storage-system with NFS blobstore) called
Finalize and WriteBlob failed, Cleanup was invoked with cleanBin=true unconditionally.
This permanently deleted the bin file from uploads/ even though the blob never reached
blobs/, making it unrecoverable — including via the move-stuck-upload-blobs CLI.

Fix: only clean the bin file when Finalize succeeds (err == nil), so a failed upload
bin is preserved for manual recovery.

https://github.com/owncloud/reva/pull/577
2 changes: 1 addition & 1 deletion pkg/storage/utils/decomposedfs/upload/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ func (session *OcisSession) FinishUploadDecomposed(ctx context.Context) error {
if !session.store.async || session.info.Size == 0 {
// handle postprocessing synchronously
err = session.Finalize(ctx)
session.Cleanup(err != nil, true, true, true)
session.Cleanup(err != nil, err == nil, true, true)
if err != nil {
log.Error().Err(err).Msg("failed to upload")
return err
Expand Down
Loading