Skip to content

fix(ci): Remove usage of nick-invision/retry #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
janpio wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

fix(ci): Remove usage of nick-invision/retry #3676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76055d3
fix(ci): Remove usage of nick-invision/retry
janpio Jul 10, 2023
7deb2c5
Merge branch 'dev' into janpio/no-retry
Jolg42 Jul 20, 2023
ce6f34d
Merge branch 'dev' into janpio/no-retry
janpio Aug 6, 2023
66253f7
Merge branch 'dev' into janpio/no-retry
janpio May 16, 2024
1d75ee3
Apply suggestions from code review
janpio May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/failing-weekly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,5 @@ jobs:

- name: test ${{ matrix.database }} - ${{matrix.clientEngine}}
id: run-test
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.database }}
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.database }}
7 changes: 2 additions & 5 deletions .github/workflows/optional-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,8 @@ jobs:

- name: test ${{ matrix.generator }} - ${{matrix.clientEngine}}
id: run-test
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.generator }}
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.generator }}

- name: notify-slack
if: failure()
Expand Down
154 changes: 55 additions & 99 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test feature - ${{ matrix.feature }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -330,11 +328,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test feature - ${{ matrix.feature }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 20
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}
id: run-test
timeout-minutes: 20
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -466,11 +462,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test feature - ${{ matrix.feature }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -516,11 +510,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test feature - ${{ matrix.feature }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.feature }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -616,11 +608,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test on ${{ matrix.os }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh generic basic ${{ matrix.os }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh generic basic ${{ matrix.os }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -776,11 +766,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test on node ${{ matrix.node }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh generic basic "node ${{ matrix.node }}"
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh generic basic "node ${{ matrix.node }}"

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -829,11 +817,9 @@ jobs:
# echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test ${{ matrix.binary }} binary on ${{ matrix.os }} using ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.binary }} ${{ matrix.os }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.binary }} ${{ matrix.os }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -905,11 +891,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: packager ${{ matrix.packager }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.packager }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.packager }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -958,11 +942,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: framework ${{ matrix.framework }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.framework }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.framework }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1017,11 +999,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test ${{ matrix.platform }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 60
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}
id: run-test
timeout-minutes: 60
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1114,11 +1094,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test ${{ matrix.platform }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 60
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}
id: run-test
timeout-minutes: 60
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1195,13 +1173,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test ${{ matrix.platform }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 60
max_attempts: 1
# default is 10s
retry_wait_seconds: 30
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}
id: run-test
timeout-minutes: 60
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1524,12 +1498,8 @@ jobs:

# see above why this is not a matrix for each DP variant
- name: test Accelerate (DP2) with extension ${{ matrix.platform }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 15
max_attempts: 3
retry_wait_seconds: 30
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}
timeout-minutes: 15
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}
env:
DATAPROXY_FLAVOR: 'DP2+Extension'
PRISMA_GENERATE_FLAG: '--accelerate'
Expand All @@ -1545,12 +1515,8 @@ jobs:

# see above why this is not a matrix for each DP variant
- name: test Accelerate (DP2) without extension ${{ matrix.platform }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 15
max_attempts: 3
retry_wait_seconds: 30
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}
timeout-minutes: 15
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.platform }}
env:
DATAPROXY_FLAVOR: 'DP2'
PRISMA_GENERATE_FLAG: '--accelerate'
Expand Down Expand Up @@ -1612,11 +1578,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test ${{ matrix.bundler }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.bundler }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.bundler }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1665,11 +1629,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test ${{ matrix.library }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.library }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.library }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1752,11 +1714,9 @@ jobs:
run: pnpm install

- name: test ${{ matrix.database }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.database }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.database }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1798,11 +1758,9 @@ jobs:
run: pnpm install

- name: test ${{ matrix.database }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.database }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.database }}

- name: notify-slack
if: failure()
Expand Down Expand Up @@ -1849,11 +1807,9 @@ jobs:
echo "DATABASE_URL=$replaced" >> $GITHUB_ENV

- name: test ${{ matrix.test-runner }} - ${{ matrix.clientEngine }}
uses: nick-invision/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.test-runner }}
id: run-test
timeout-minutes: 10
run: bash .github/scripts/test-project.sh ${{ github.job }} ${{ matrix.test-runner }}

- name: notify-slack
if: failure()
Expand Down