Fix HiDPI related error in column autosize code in TJvDBGrid#200
Open
Torbins wants to merge 1 commit intoproject-jedi:masterfrom
Open
Fix HiDPI related error in column autosize code in TJvDBGrid#200Torbins wants to merge 1 commit intoproject-jedi:masterfrom
Torbins wants to merge 1 commit intoproject-jedi:masterfrom
Conversation
obones
requested changes
Jun 6, 2025
| try | ||
| // Get useable width | ||
| ColLineWidth := Ord(dgColLines in Options) * GridLineWidth; | ||
| ColLineWidth := PPIScale(Self, ColLineWidth); |
Member
There was a problem hiding this comment.
Why introduce a new assignment when the call to PPIScale could be made inline, just like what's done elsewhere?
Author
There was a problem hiding this comment.
I have written this code in Delphi 11 and was not sure about changes in Delphi 12. Now it looks like code related to GridLineWidth is stable, and conditional compilation will not be required. I can change this fix to be inline.
obones
force-pushed
the
column_autosize_hidpi_bug
branch
from
e24edb9 to
771c00d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On HiDPI screens column widths are calculated incorrectly in TJvDBGrid. This leads to horizontal scrollbar appearing and grid content scrolling horizontally when user is trying to edit data in last column.