Skip to content

Fix HiDPI related error in column autosize code in TJvDBGrid #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Torbins wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix HiDPI related error in column autosize code in TJvDBGrid #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jvcl/run/JvDBGrid.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4320,6 +4320,7 @@ procedure TJvDBGrid.DoAutoSizeColumns;
try
// Get useable width
ColLineWidth := Ord(dgColLines in Options) * GridLineWidth;
ColLineWidth := PPIScale(Self, ColLineWidth);
Copy link
Copy Markdown
Member

@obones obones Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introduce a new assignment when the call to PPIScale could be made inline, just like what's done elsewhere?

Copy link
Copy Markdown
Author

@Torbins Torbins Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have written this code in Delphi 11 and was not sure about changes in Delphi 12. Now it looks like code related to GridLineWidth is stable, and conditional compilation will not be required. I can change this fix to be inline.

Copy link
Copy Markdown
Member

@obones obones Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any news?

AvailableWidth := ClientWidth;
if (dgIndicator in Options) then
Dec(AvailableWidth, PPIScale(Self, IndicatorWidth) + ColLineWidth);
Expand Down