Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes FRLM’s VMT coverage fallback path so get_vmt_coverage() no longer calls a non-existent flow coverage method when flow_coverage has been removed, and adds a regression test to prevent the AttributeError reported in issue #520.
Changes:
- Update
FRLM.get_vmt_coverage()to initialize missingflow_coveragestate and delegate to the existingget_flow_coverage()implementation. - Add a regression test that deletes
flow_coveragebefore callingget_vmt_coverage()and asserts VMT metrics are returned.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spopt/locate/flow.py |
Fixes the fallback in get_vmt_coverage() by initializing flow_coverage and calling get_flow_coverage() instead of a missing method. |
spopt/tests/test_locate/test_flow.py |
Adds a regression test covering the missing-flow_coverage attribute scenario from issue #520. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=======================================
+ Coverage 76.9% 77.0% +0.1%
=======================================
Files 29 29
Lines 3700 3701 +1
=======================================
+ Hits 2846 2849 +3
+ Misses 854 852 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #520 by correcting the fallback path in
FRLM.get_vmt_coverage()so it initialises missing flow coverage state and delegates to the existingget_flow_coverage()method rather than calling a non-existent method, and it adds a regression test that removesflow_coveragebefore invocation to confirm the method now returns VMT metrics instead of raisingAttributeError.