Skip to content

fix: repair FRLM VMT coverage fallback #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samay2504 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: repair FRLM VMT coverage fallback #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spopt/locate/flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,8 @@ def get_vmt_coverage(self) -> dict[str, float]:
self._calculate_path_distances()

if not hasattr(self, "flow_coverage"):
self.calculate_flow_coverage()
self.flow_coverage = {}
self.get_flow_coverage()

total_vmt = 0
covered_vmt = 0
Expand Down
11 changes: 11 additions & 0 deletions spopt/tests/test_locate/test_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,17 @@ def test_detailed_results(self, setup_solved_model):
assert params["p_facilities"] == 2
assert params["objective_type"] == "flow"

def test_vmt_coverage_without_flow_coverage_attr(self, setup_solved_model):
model = setup_solved_model
if hasattr(model, "flow_coverage"):
delattr(model, "flow_coverage")

metrics = model.get_vmt_coverage()

assert "total_vmt" in metrics
assert "covered_vmt" in metrics
assert "vmt_coverage_percentage" in metrics


class TestFRLMCustomPaths:
def test_custom_paths_basic(self):
Expand Down
Loading