[4/N] Add backend options map by cccclai · Pull Request #11462 · pytorch/executorch

cccclai · 2025-06-06T23:49:36Z

Stack from ghstack (oldest at bottom):

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend.
@exported-using-ghexport

Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

pytorch-bot · 2025-06-06T23:49:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11462

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Unrelated Failures

As of commit 6be49e1 with merge base 608a745 ():

NEW FAILURES - The following jobs have failed:

Lint / lintrunner / linux-job (gh)
>>> Lint for runtime/backend/interface.h:
pull / unittest-buck / macos / macos-job (gh)
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/tuple:1451:5: error: static assertion failed due to requirement 'value != __not_found': type not found in type list

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-models-linux (add_mul, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
pull / test-quantized-aot-lib-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / unittest-buck / linux / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-06-06T23:50:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot · 2025-06-06T23:50:33Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

facebook-github-bot · 2025-06-10T18:40:27Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T21:36:58Z

This pull request was exported from Phabricator. Differential Revision: D76149466

runtime/backend/backend_options.h

kimishpatel · 2025-06-13T03:06:35Z

runtime/backend/backend_options.h

+  executorch::runtime::ArrayRef<BackendOption> view() const {
+    return executorch::runtime::ArrayRef<BackendOption>(options_, size_);
+  }


is this method needed?

kimishpatel · 2025-06-13T03:07:09Z

runtime/backend/backend_options_map.h

+};
+
+template <size_t MaxBackends>
+class BackendOptionsMap {


why do we need this?

This is to manage the mapping between backend_name and backend options. Like
{
"XNNPACK": ["profile": true, "thread": 4],
"QNN": ["power": "high"],
}

Can you not just use set_option and get_option? We discussed this by allowing users to directly set backend options, without having to plumb it through methods/program etc., and I belive you did that? In that case do we still need this?

backend options map is for setting multiple backends, users code will be like following

// users' code BackendOptions backend_options = { {"CoreMLBackend", {{"power", "high"}}}, {"QNNBackend", {{"backend", "CPU_AND_ANE"}}} }; // Optional update(backend_options); module.load(file); // Optional update(backend_options); module.execute(inputs);

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

Pull Request resolved: #11462 This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. ghstack-source-id: 290371659 @exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/)

facebook-github-bot · 2025-06-13T22:31:17Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

facebook-github-bot · 2025-06-17T16:13:30Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466) [ghstack-poisoned]

facebook-github-bot · 2025-06-17T18:23:42Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466) [ghstack-poisoned]

facebook-github-bot · 2025-06-18T05:54:36Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466) [ghstack-poisoned]

facebook-github-bot · 2025-06-18T06:06:01Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466) [ghstack-poisoned]

facebook-github-bot · 2025-06-23T05:08:10Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466) [ghstack-poisoned]

facebook-github-bot · 2025-06-23T05:12:06Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466) [ghstack-poisoned]

facebook-github-bot · 2025-06-23T18:39:17Z

This pull request was exported from Phabricator. Differential Revision: D76149466

kimishpatel

I am not 100% convinced we need this, but not strongly opposed to it. Leave it to the author

Pull Request resolved: pytorch/executorch#11462 This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. ghstack-source-id: 290371659 @exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/)

github-actions · 2025-09-02T00:51:13Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2025-11-01T00:51:33Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-01-01T00:51:42Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-02T00:55:21Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

meta-cla · 2026-04-11T02:34:21Z

Hi @cccclai!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025

This was referenced Jun 6, 2025

[1/N] Add BackendOptions class #11389

Merged

[2/N] Add option context #11390

Merged

[3/N] Add get_option/set_option function in backend interface #11391

Merged

[5/N] Add update in method #11463

Open

facebook-github-bot added the fb-exported label Jun 6, 2025

This was referenced Jun 10, 2025

[6/N] Add update in module #11533

Open

[7/N] Add sugar syntax for module.update #11534

Open

kimishpatel reviewed Jun 13, 2025

View reviewed changes

runtime/backend/backend_options.h Outdated Show resolved Hide resolved

kimishpatel reviewed Jun 13, 2025

View reviewed changes

This was referenced Jun 17, 2025

Support Span to construct from a single element similar to ArrayRef #11757

Merged

[5/N] Add get_option/set_option APIs #11758

Open

kimishpatel approved these changes Jun 23, 2025

View reviewed changes

github-actions bot added the stale PRs inactive for over 60 days label Sep 2, 2025

Conversation

cccclai commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11462

❌ 2 New Failures, 4 Unrelated Failures

Uh oh!

github-actions bot commented Jun 6, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

Uh oh!

kimishpatel Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

cccclai Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

cccclai Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

facebook-github-bot commented Jun 18, 2025

Uh oh!

facebook-github-bot commented Jun 18, 2025

Uh oh!

facebook-github-bot commented Jun 23, 2025

Uh oh!

facebook-github-bot commented Jun 23, 2025

Uh oh!

facebook-github-bot commented Jun 23, 2025

Uh oh!

kimishpatel left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Jan 1, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

meta-cla bot commented Apr 11, 2026

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cccclai commented Jun 6, 2025 •

edited

Loading

pytorch-bot bot commented Jun 6, 2025 •

edited

Loading

This PR needs a `release notes:` label