[5/N] Add update in method by cccclai · Pull Request #11463 · pytorch/executorch

cccclai · 2025-06-06T23:49:41Z

Stack from ghstack (oldest at bottom):

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood.

Differential Revision: D76149467

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

pytorch-bot · 2025-06-06T23:49:44Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11463

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated Failures

As of commit a26ada5 with merge base f7cc72f ():

NEW FAILURE - The following job has failed:

Lint / lintrunner / linux-job (gh)

CANCELLED JOB - The following job was cancelled. Please retry:

pull / unittest-editable / macos / macos-job (gh)
##[error]The operation was canceled.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / linux / linux-job (gh) (trunk failure)
.ci/scripts/tests/test_gather_benchmark_configs.py::TestGatehrBenchmarkConfigs::test_generate_compatible_configs_quantized_llama_model
pull / unittest-editable / linux / linux-job (gh) (trunk failure)
.ci/scripts/tests/test_gather_benchmark_configs.py::TestGatehrBenchmarkConfigs::test_generate_compatible_configs_quantized_llama_model

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) ghstack-source-id: 288753956 Pull Request resolved: #11463

github-actions · 2025-06-06T23:50:22Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot · 2025-06-06T23:50:36Z

This pull request was exported from Phabricator. Differential Revision: D76149467

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

facebook-github-bot · 2025-06-10T18:40:55Z

This pull request was exported from Phabricator. Differential Revision: D76149467

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T21:37:02Z

This pull request was exported from Phabricator. Differential Revision: D76149467

kimishpatel · 2025-06-13T03:08:32Z

runtime/executor/test/method_update_test.cpp

+   void load_program() {
+    // Since these tests cause ET_LOG to be called, the PAL must be initialized
+    // first.
+    executorch::runtime::runtime_init();


This already happens in Setup too

kimishpatel · 2025-06-13T03:11:54Z

runtime/executor/method.cpp

+    const char* backend_name = entry.backend_name;
+    auto backend_options = entry.options;
+
+    auto backend_class = get_backend_class(backend_name);


does backend class give you a singleton instance of backend interface? If so why do we need to pipe it up via Method class. Just make something like executorch::backend::set_options(BackendOptions&) (I dont think BackendOptions constructor exist? but probably would be good to add)

No it doesn't. I did only for the test backend I added, just so I can check if the config inside the backend is indeed changed in the test.

I agree. Allowing it to pass via Method or Module hints that it is private to a method which in fact it isn't.

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

facebook-github-bot · 2025-06-13T22:33:27Z

This pull request was exported from Phabricator. Differential Revision: D76149467

Pull Request resolved: pytorch/executorch#11463 Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. ghstack-source-id: 290372282 @exported-using-ghexport Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/)

github-actions · 2025-11-01T00:51:34Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-01-01T00:51:43Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-03-02T00:55:22Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

meta-cla · 2026-04-11T02:38:47Z

Hi @cccclai!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[5/N] Add update in method

1596ba3

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

cccclai requested review from JacobSzwejbka, kirklandsign, larryliu0820, lucylq and swolchok as code owners June 6, 2025 23:49

This was referenced Jun 6, 2025

[1/N] Add BackendOptions class #11389

Merged

[2/N] Add option context #11390

Merged

This was referenced Jun 6, 2025

[3/N] Add get_option/set_option function in backend interface #11391

Merged

[4/N] Add backend options map #11462

Open

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025

facebook-github-bot added the fb-exported label Jun 6, 2025

Update on "[5/N] Add update in method"

f1f105c

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

This was referenced Jun 10, 2025

[6/N] Add update in module #11533

Open

[7/N] Add sugar syntax for module.update #11534

Open

Update on "[5/N] Add update in method"

142fdbd

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

kimishpatel reviewed Jun 13, 2025

View reviewed changes

Update on "[5/N] Add update in method"

a26ada5

Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood. Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/) [ghstack-poisoned]

github-actions bot added the stale PRs inactive for over 60 days label Nov 1, 2025

Conversation

cccclai commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11463

❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated Failures

Uh oh!

github-actions bot commented Jun 6, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

kimishpatel Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

cccclai Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

digantdesai Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Jan 1, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

meta-cla bot commented Apr 11, 2026

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cccclai commented Jun 6, 2025 •

edited

Loading

pytorch-bot bot commented Jun 6, 2025 •

edited

Loading

This PR needs a `release notes:` label

cccclai Jun 13, 2025 •

edited

Loading