You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
Overview: Small docs-only PR that improves the serverless production checklist with clearer, more actionable guidance on concurrency caps, requestLifespan, and drainGracePeriod tuning. Also appends driver test re-run results to the agent notes file.
.agent/notes/driver-test-progress.md
No concerns — log entries follow the existing format and all 6 DB file groups are reported as passing.
The rewritten concurrency bullet is a clear improvement. It explains why per-instance concurrency matters (one actor per in-flight /api/rivet/start) and names concrete platform knobs (--concurrency, reserved concurrency, maxDuration).
Adding separate bullets for requestLifespan and drainGracePeriod surfaces tuning that was previously invisible to operators — good addition.
Issues to verify:
Vercel tier values look swapped. The bullet reads 295 for Vercel Hobby, 3595 for Vercel Pro. Vercel Hobby serverless functions have a 60-second hard timeout, not ~300 s. 295 s is 5 s below Vercel Pro's 300 s limit. Consider double-checking and using something like:
Hobby: 55 (below the 60 s cap)
Pro: 295 (below the 300 s cap)
Enterprise/streaming: 3595 (if applicable)
Using the wrong value could cause operators on Hobby to set a requestLifespan that exceeds their actual platform limit, resulting in forcibly killed requests.
AWS Lambda reserved concurrency framing. The bullet groups "AWS Lambda reserved concurrency" under the per-instance concurrency examples. Lambda reserved concurrency is a total concurrent-execution cap across all instances, not a per-instance setting. The most relevant Lambda knob is that Lambda is inherently single-threaded (one event at a time per instance), so per-instance concurrency is always 1. This could mislead Lambda users. Consider either dropping the Lambda example or clarifying that Lambda concurrency is always 1 per instance by default.
drainGracePeriod default. The bullet says "Default is 30 minutes from the engine". If this differs from the value surfaced by configurePool or the value a user would see in generated docs, it may cause confusion. Worth confirming the canonical default before merge.
Link validity. The requestLifespan bullet links to /docs/general/runtime-modes#timeouts and the drainGracePeriod bullet links to /docs/actors/limits. If those anchors or pages do not exist yet, the links will 404. Worth verifying both resolve correctly.
Summary: The intent and structure of these docs improvements are solid. The main thing to address before merge is the Vercel Hobby timeout value — using an incorrect example there is the most likely source of real operator pain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: