Skip to content

temp: patch wasm-pack to point to latest binary#5037

Draft
abcxff wants to merge 1 commit into
counter-latency/require-engine-ping-healthfrom
05-11-fix_wasm_point_wasm-pack_build_to_new_wasm-bindgen_repo
Draft

temp: patch wasm-pack to point to latest binary#5037
abcxff wants to merge 1 commit into
counter-latency/require-engine-ping-healthfrom
05-11-fix_wasm_point_wasm-pack_build_to_new_wasm-bindgen_repo

Conversation

@abcxff
Copy link
Copy Markdown
Contributor

@abcxff abcxff commented May 11, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abcxff
Copy link
Copy Markdown
Contributor Author

abcxff commented May 11, 2026

See wasm-bindgen/wasm-pack#1577

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 11, 2026

PR Review for PR 5037 (temp: patch wasm-pack)

Overview: Patches wasm-pack@0.14.0 to fix its binary download URL (moved from drager to wasm-bindgen org), bumps from 0.13.1 to 0.14.0, and disables the build-wasm CI job.

ISSUE 1 - Stale pnpm-lock.yaml override (bug): package.json removed the wasm-pack entry from overrides, but pnpm-lock.yaml line 26 still reads wasm-pack: =0.13.1. The lock file also retains a wasm-pack@0.13.1 snapshot near line 17998. Run pnpm install and recommit the updated lock file.

ISSUE 2 - Commented-out CI job leaves dead code: The entire build-wasm job is commented out in publish.yaml rather than deleted. If temporary, add an inline comment explaining the condition to re-enable. If the wasm package is no longer published, delete the job and remove references to rivetkit-typescript/packages/rivetkit-wasm/pkg from downstream steps.

ISSUE 3 - Missing newline at end of package.json: The diff shows No newline at end of file. Add a trailing newline.

CONCERN - Supply chain: The patch redirects binary downloads from github.com/drager/wasm-pack to github.com/wasm-bindgen/wasm-pack. This appears correct given the project transferred orgs, but confirm the new release URL resolves to the expected artifact before merging.

CONCERN - Patch fragility: Patching binary.js is a reasonable short-term workaround. Once wasm-pack ships an npm release with the corrected URL, this patch and the patchedDependencies entry can be dropped.

Summary: The core change (patching the download URL) is the right approach. Three things to fix before merging: regenerate the lock file to remove the stale =0.13.1 override, add a trailing newline to package.json, and either delete the commented-out build-wasm job or add a note explaining when to restore it.

@abcxff abcxff changed the title fix(wasm): point wasm-pack build to new wasm-bindgen repo temp: remove wasm build step May 11, 2026
@abcxff abcxff changed the title temp: remove wasm build step temp: remove wasm publish step May 11, 2026
@abcxff abcxff force-pushed the 05-11-fix_wasm_point_wasm-pack_build_to_new_wasm-bindgen_repo branch from e872ef5 to d644728 Compare May 11, 2026 19:23
@abcxff abcxff changed the title temp: remove wasm publish step temp: patch wasm-pack to point to latest binary May 11, 2026
@abcxff abcxff force-pushed the 05-11-fix_wasm_point_wasm-pack_build_to_new_wasm-bindgen_repo branch from d644728 to abf9ff9 Compare May 11, 2026 19:58
@MasterPtato MasterPtato force-pushed the counter-latency/require-engine-ping-health branch from 8e4c5f6 to eaa41b2 Compare May 14, 2026 17:26
@MasterPtato MasterPtato force-pushed the 05-11-fix_wasm_point_wasm-pack_build_to_new_wasm-bindgen_repo branch from abf9ff9 to 40c3589 Compare May 14, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant