Add ResetWorld service to reset to a specific defined keyframe#95
Merged
saikishor merged 9 commits intoros-controls:mainfrom Feb 4, 2026
Merged
Conversation
eholum-nasa
approved these changes
Feb 4, 2026
Collaborator
eholum-nasa
left a comment
eholum-nasa
left a comment
There was a problem hiding this comment.
🚀
Tested and it delivers!
Still not sure what's up with our mobile sim and keyframes but other sims work so ship it. Also pixi in CI is giving me all kinds of trouble in other projects too so I'm going to dig into here separately... please merge past the failure...
Member
Author
|
Thank you @eholum-nasa. I tried to handle Pixi CI, but couldn't solve it easily. As per your instructions, I'll go ahead and merhe it 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, I've added a new service message type that would allow the users to switch to certain keyframe. If no keyframe is defined, it resets to the initial position