If an error occurs try and recover from it if necessary#310
Open
matt-attack wants to merge 1 commit intoros-industrial:indigo-develfrom
Open
If an error occurs try and recover from it if necessary#310matt-attack wants to merge 1 commit intoros-industrial:indigo-develfrom
matt-attack wants to merge 1 commit intoros-industrial:indigo-develfrom
Conversation
|
Related to #244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were having issues with the driver refusing to send packets after an error of some type occurred on the bus, likely due to the hardware on the other end. Simply recovering was able to fix the problem. This is probably not the best way to do it, but it definitely works.
Related to #267
It may be good to just add a parameter to enable or disable this functionality and merge it in as a stopgap until the fancier solution #249 is complete. This node is useless to us without this functionality.