When SHM enabled, enable transport_optimization (backport #1020) - #1023
Merged
Conversation
(cherry picked from commit e315985) # Conflicts: # docs/design.md
Author
|
Cherry-pick of e315985 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Author
|
Tick the box to add this pull request to the merge queue (same as
|
… branch Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
ahcorde
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #857 rmw_zenoh is using the same SHM segment than created by Zenoh when
transport_optimizationis enabled. While it checks iftransport/shared_memory/enabled==trueit doesn't check nor enforce thattransport/shared_memory/transport_optimization==true.If SHM is enabled and
transport_optimizationis disabled, SHM is not used and rmw_zenoh fallbacks to network transport.This PR overwrites the config with
transport/shared_memory/transport_optimization: trueif set tofalseand SHM is enabled. An INFO log is also displayed.Is this user-facing behavior change?
No
Did you use Generative AI?
No
This is an automatic backport of pull request #1020 done by [Mergify](https://mergify.com).