Add cli option compression-threads-priority#1768
Merged
MichaelOrlov merged 5 commits intoros2:rollingfrom Aug 9, 2024
Merged
Conversation
Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>
r7vme
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
Contributor
Author
|
@MichaelOrlov PTAL |
Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>
fujitatomoya
approved these changes
Aug 5, 2024
Contributor
Author
|
@fujitatomoya thanks for the review. I see a lot of unrealed issues in CI Did you see smth similar? |
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
- Rationale: To test the same behavior as in the writer factory class Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
approved these changes
Aug 9, 2024
Contributor
MichaelOrlov
left a comment
MichaelOrlov
left a comment
There was a problem hiding this comment.
@r7vme Thanks for your contribution.
Overall looks good. However, I added some minor changes in the help section and doxygen comments to better explain what values could be for the compression thread's priority.
Contributor
|
Pulls: #1768
|
Contributor
Author
|
@MichaelOrlov LGTM, thanks |
Contributor
|
Linux CI job failed due to insufficient disk space on the test machine.
|
Contributor
|
Re-running CI job one more time after one more attempt to fix build infrastructure.
|
Contributor
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Add cli option compression-threads-priority Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Fix CI issues Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Add timeout for the test_priority_propagated_into_compression_thread Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Update help section and doxygen comments for thread priority parameters Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use integer type for compression threads priority default value in tests - Rationale: To test the same behavior as in the writer factory class Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 25c3e1c)
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Add cli option compression-threads-priority Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Fix CI issues Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Add timeout for the test_priority_propagated_into_compression_thread Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Update help section and doxygen comments for thread priority parameters Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use integer type for compression threads priority default value in tests - Rationale: To test the same behavior as in the writer factory class Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 25c3e1c)
MichaelOrlov
pushed a commit
that referenced
this pull request
Aug 10, 2024
* Add cli option compression-threads-priority Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Fix CI issues Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Add timeout for the test_priority_propagated_into_compression_thread Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Update help section and doxygen comments for thread priority parameters Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use integer type for compression threads priority default value in tests - Rationale: To test the same behavior as in the writer factory class Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 25c3e1c) Co-authored-by: Roman <rsokolkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--compression-threads-priorityCLI parameter for theros2 bag recordcommand to be able to set up compression threads priority.