feat: adding isJSX arg in share generator#29
Open
maitzeth wants to merge 1 commit intortivital:masterfrom
Open
feat: adding isJSX arg in share generator#29maitzeth wants to merge 1 commit intortivital:masterfrom
maitzeth wants to merge 1 commit intortivital:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Vitaly, I didn't want to do a complete refactor of this, so I just made a small and simple change inside generateShape.
The problem was quite simple: whenever I copy the to the clipboard in JSX format, the styling is always inline CSS. So, this is just a small UX improvement.