Skip to content

feat: adding isJSX arg in share generator #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maitzeth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: adding isJSX arg in share generator #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/apps/page-dividers/Output/generate-example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
const generateShape = (content) => (props) => `<div style="overflow: hidden;">
<svg
preserveAspectRatio="none"
viewBox="0 0 1200 120"
xmlns="http://www.w3.org/2000/svg"
${props}
>
${content}
</svg>
</div>`;
const generateShape = (content) => (props, isJSX) => {
return `
<div style=${isJSX ? "{{ overflow: 'hidden' }}" : '"overflow: hidden;"'}>
<svg
preserveAspectRatio="none"
viewBox="0 0 1200 120"
xmlns="http://www.w3.org/2000/svg"
${props}
>
${content}
</svg>
</div>`;
};

const shapes = {
tilt: generateShape('<path d="M1200 120L0 16.48V0h1200v120z" />'),
Expand Down Expand Up @@ -49,14 +52,14 @@ function generateHtml(values) {
const transformValue = getTransformValue(values);
const transform = transformValue ? ` transform: ${transformValue};` : '';
const style = `fill: ${values.color}; width: ${values.width}%; height: ${values.height}px;${transform}`;
return shapes[values.type](`style="${style}"`);
return shapes[values.type](`style="${style}"`, false);
}

function generateJSX(values) {
const transformValue = getTransformValue(values);
const transform = transformValue ? ` transform: '${transformValue}'` : '';
const style = `fill: '${values.color}', width: '${values.width}%', height: ${values.height},${transform}`;
return shapes[values.type](`style={{ ${style} }}`);
return shapes[values.type](`style={{ ${style} }}`, true);
}

const types = {
Expand Down