Support selecting target buffer - #50
Closed
randomPoison wants to merge 1 commit into
Closed
Conversation
* Add `LogId` enum to identify the different log buffers. * Add an argument to `PlatformLogWriter::new` to allow a target buffer to be specified. * Update `Config` to allow specifying a target buffer.
Collaborator
|
@randomPoison I have merged other PRs that are simpler, so this one that gets the conflicts. Let me know if you are still interested in getting this merged. |
Contributor
|
Hello, Can we get this PR merged? |
Collaborator
|
@rsglobal Hi, not until the conflicts are resolved. |
Contributor
tyranron
added
wontfix
k::api
Contributor
|
Superseded by #64 |
tyranron
added a commit
that referenced
this pull request
Feb 14, 2023
- add `LogId` enum to identify the different log buffers - add `buf_id` argument to `PlatformLogWriter::new()` - add `Config::with_log_buffer()` allowing to specify target buffer Co-authored-by: David LeGare <dlegare.1001@gmail.com> Co-authored-by: Kai Ren <tyranron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #49.
LogIdenum to identify the different log buffers.PlatformLogWriter::newto allow a target buffer to be specified.Configto allow specifying a target buffer.This change, as it exists currently, is a breaking change for any users who are currently calling
PlatformLogWriter::newdirectly. It should not break any users who are usingConfigwithinit_once. If this is undesirable then I'm open to updating the PR to avoid breaking changes.Note also that these changes depend on an update to android_log-sys in order to expose
__android_log_buf_write. See Nercury/android_log-sys-rs#4.