rebase: Support selecting target buffer - #64
Merged
Conversation
rsglobal
changed the title
Contributor
Author
|
Rebased, cargo test passes, not tested with my project yet. |
rsglobal
force-pushed
the
rebase-log-id
branch
from
February 13, 2023 22:24
29c86b7 to
afb7ed8
Compare
Contributor
Author
|
I tested it on Android device and was able to switch buffer to radio and see logs from there |
Nercury
approved these changes
Feb 14, 2023
Collaborator
|
I think it's good, but since I am not alone in maintaining this please @tyranron, can you take a look too? |
rsglobal
force-pushed
the
rebase-log-id
branch
from
February 14, 2023 10:24
afb7ed8 to
78c2507
Compare
* Add `LogId` enum to identify the different log buffers. * Add an argument to `PlatformLogWriter::new` to allow a target buffer to be specified. * Update `Config` to allow specifying a target buffer.
rsglobal
force-pushed
the
rebase-log-id
branch
from
February 14, 2023 10:24
78c2507 to
44c50e8
Compare
tyranron
added
k::api
tyranron
approved these changes
Feb 14, 2023
Contributor
Contributor
Author
|
Thanks for quick merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #50
LogIdenum to identify the different log buffers.PlatformLogWriter::newto allow a target buffer to be specified.Configto allow specifying a target buffer.