Add LSP-Relay

[Tyderion]

No description provided.

[STReviewBot]

Automated testing result: SUCCESS

Repo link: LSP-Relay

Packages added:
  - LSP-Relay

Processing package "LSP-Relay"
  - All checks passed

[STReviewBot]

Automated testing result: SUCCESS

Repo link: LSP-Relay

Packages added:
  - LSP-Relay

Processing package "LSP-Relay"
  - All checks passed

[rchl]

• Is there a reason you have your own 'server.js' instead of directly pointing at cli.js from relay-compiler?
• If you use https://github.com/sublimelsp/LSP/blob/dfd3a91cf5a4070e23a98f86800d26d706e51b1f/plugin/core/sessions.py#L1025-L1041 then you should have access to resolved configuration and workspace folders through its arguments and shouldn't need to read settings manually or merge project settings.
• Are you open to moving this package to sublimelsp organization? It helps with synchronizing braking changes within ecosystem.

[Tyderion]

wow thanks for your quick review!

1. cli.js - no, not really, i just adjusted the LSP-graphql package, but just using cli.js makes more sense
2. on_pre_start - oh i didn't know about that, we can of course change the code to use the already merged configuration from there
3. sure, we can absolutely move the package to that github repo

[rchl]

Actually, the config with settings that you can access from can_start only has access to settings in initializationOptions and settings object. So you would need to move your custom settings to one of those (servers usually don't care about unknown keys).

[Tyderion]

thanks for the input. i'll fix/change it to use cli.js and the correct place to specify/read custom settings and i'll give you another ping, then we can move a correctly implemented version to the sublimelsp organization

[rchl]

Created https://github.com/sublimelsp/LSP-Relay and invited you to become a maintainer.

Ideally you could create a PR against the main branch so that we get extra visibility on the whole code and have an easy way to make suggestions.

[Tyderion]

thanks for the repo @rchl i rebased and pushed to that repository on a new branch, see the full PR here: sublimelsp/LSP-relay#1

[STReviewBot]

Automated testing result: ERROR

Repo link: LSP-Relay
Results help

Packages added:
  - LSP-Relay

Processing package "LSP-Relay"
  - ERROR: No valid semver tags found at https://github.com/sublimelsp/LSP-Relay/tags for the package "LSP-Relay".