chore: remove GPU logs when feature is disabled#2415
chore: remove GPU logs when feature is disabled#2415vprashar2929 wants to merge 1 commit intosustainable-computing-io:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2415 +/- ##
==========================================
- Coverage 91.98% 91.92% -0.07%
==========================================
Files 54 54
Lines 5365 5362 -3
==========================================
- Hits 4935 4929 -6
- Misses 310 312 +2
- Partials 120 121 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 21869646546 -n profile-artifacts-2415 |
f0711de to
4116bb5
Compare
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 21979576173 -n profile-artifacts-2415 |
4116bb5 to
0fef335
Compare
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 22036084786 -n profile-artifacts-2415 |
0fef335 to
1b0ee8c
Compare
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 22054848564 -n profile-artifacts-2415 |
| // Returns empty slice if GPU is not enabled or no GPUs are available (soft-fail). | ||
| func createGPUMeters(logger *slog.Logger, cfg *config.Config) []gpu.GPUPowerMeter { | ||
| if !cfg.IsFeatureEnabled(config.ExperimentalGPUFeature) { | ||
| logger.Info("GPU feature disabled") |
There was a problem hiding this comment.
i don't agree that this is noise.
There was a problem hiding this comment.
This creates confusion. If something is not used why logging then?
This commit removes the GPU related log noise that appears when the experimental GPU feature is disabled Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com>
1b0ee8c to
1d783ef
Compare
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 22062205591 -n profile-artifacts-2415 |
This commit removes the GPU related log noise that appears when the experimental GPU feature is disabled