Skip to content

chore: remove GPU logs when feature is disabled #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vprashar2929 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −7
Open

chore: remove GPU logs when feature is disabled #2415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/kepler/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@ func createCPUMeter(logger *slog.Logger, cfg *config.Config) (device.CPUPowerMet
// Returns empty slice if GPU is not enabled or no GPUs are available (soft-fail).
func createGPUMeters(logger *slog.Logger, cfg *config.Config) []gpu.GPUPowerMeter {
if !cfg.IsFeatureEnabled(config.ExperimentalGPUFeature) {
logger.Info("GPU feature disabled")
Copy link
Collaborator

@vimalk78 vimalk78 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't agree that this is noise.

Copy link
Collaborator Author

@vprashar2929 vprashar2929 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates confusion. If something is not used why logging then?

return nil
}

Expand Down
8 changes: 2 additions & 6 deletions internal/monitor/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,8 @@ func (pm *PowerMonitor) Init() error {
"zone", primaryEnergyZone.Name())

// Log GPU meter status
if len(pm.gpuMeters) > 0 {
for _, m := range pm.gpuMeters {
pm.logger.Info("GPU meter configured", "vendor", m.Vendor(), "devices", len(m.Devices()))
}
} else {
pm.logger.Info("No GPU meters configured")
for _, m := range pm.gpuMeters {
pm.logger.Info("GPU meter configured", "vendor", m.Vendor(), "devices", len(m.Devices()))
}

// Initialize terminated workload trackers with the primary energy zone and minimum energy threshold
Expand Down
Loading