fix(auth): Surface real apple sign In error and harden crashlytics de…#202
Merged
Conversation
Code Review SummaryThe PR improves error reporting for Apple Sign-In by capturing and surface specific error messages. It also ensures Firebase Crashlytics is actively collecting and sending reports. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| Future<void> initialize() async { | ||
| try { | ||
| setupFlutterErrorHandling(); | ||
| await _crashlyticsInstance.setCrashlyticsCollectionEnabled(true); |
There was a problem hiding this comment.
While enabling collection is good for production, hardcoding 'true' here might override environment-specific configurations (e.g., disabling crashlytics in dev). Consider using a configuration flag.
Suggested change
| await _crashlyticsInstance.setCrashlyticsCollectionEnabled(true); | |
| if (!kDebugMode) { | |
| await _crashlyticsInstance.setCrashlyticsCollectionEnabled(true); | |
| } | |
| await _crashlyticsInstance.sendUnsentReports(); |
| }, | ||
| ); | ||
| return const Left(Failure.unauthorizedError()); | ||
| return Left(Failure.badRequest( |
There was a problem hiding this comment.
Changing from 'unauthorizedError' to 'badRequest' with a string message is a functional change. Ensure the UI layer is prepared to display this raw error message to users, as 'e.message' from Apple might contain technical jargon.
Suggested change
| return Left(Failure.badRequest( | |
| return Left(Failure.unauthorizedError(message: 'Apple Sign-In failed: ${e.message}')); |
nfebe
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resurface Apple signing exception
Type of Change