-
Notifications
You must be signed in to change notification settings - Fork 5
fix(auth): Surface real apple sign In error and harden crashlytics de… #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,20 +1,21 @@ | ||||||
| import 'dart:convert'; | ||||||
| import 'dart:math'; | ||||||
| import 'dart:io'; | ||||||
| import 'package:google_sign_in/google_sign_in.dart'; | ||||||
| import 'package:sign_in_with_apple/sign_in_with_apple.dart'; | ||||||
| import 'package:firebase_auth/firebase_auth.dart'; | ||||||
| import 'dart:math'; | ||||||
|
|
||||||
| import 'package:crypto/crypto.dart'; | ||||||
| import 'package:firebase_auth/firebase_auth.dart'; | ||||||
| import 'package:fpdart/fpdart.dart'; | ||||||
| import 'package:google_sign_in/google_sign_in.dart'; | ||||||
| import 'package:injectable/injectable.dart'; | ||||||
| import 'package:trakli/core/utils/services/logger.dart' show logger; | ||||||
| import 'package:trakli/core/error/repository_error_handler.dart'; | ||||||
| import 'package:trakli/core/error/exceptions.dart'; | ||||||
| import 'package:sign_in_with_apple/sign_in_with_apple.dart'; | ||||||
| import 'package:trakli/core/error/crash_reporting/crash_reporting_service.dart'; | ||||||
| import 'package:trakli/core/error/exceptions.dart'; | ||||||
| import 'package:trakli/core/error/failures/failures.dart'; | ||||||
| import 'package:trakli/core/error/repository_error_handler.dart'; | ||||||
| import 'package:trakli/core/utils/services/logger.dart' show logger; | ||||||
| import 'package:trakli/data/datasources/auth/auth_remote_data_source.dart'; | ||||||
| import 'package:trakli/di/injection.dart'; | ||||||
| import 'package:trakli/domain/entities/user_entity.dart'; | ||||||
| import 'package:fpdart/fpdart.dart'; | ||||||
| import 'package:trakli/core/error/failures/failures.dart'; | ||||||
| import 'package:trakli/domain/repositories/auth_repository.dart'; | ||||||
|
|
||||||
| /// Service to handle OAuth authentication with backend API integration. | ||||||
|
|
@@ -111,15 +112,13 @@ class OAuthService { | |||||
| } on FirebaseAuthException catch (e, stackTrace) { | ||||||
| logger.e('Google Sign-In Firebase error: ${e.code} - ${e.message}', | ||||||
| error: e); | ||||||
| await _crashReporting.recordError( | ||||||
| e, | ||||||
| stackTrace: stackTrace, | ||||||
| reason: 'Google Sign-In FirebaseAuthException', | ||||||
| information: { | ||||||
| 'code': e.code, | ||||||
| 'message': e.message ?? '', | ||||||
| } | ||||||
| ); | ||||||
| await _crashReporting.recordError(e, | ||||||
| stackTrace: stackTrace, | ||||||
| reason: 'Google Sign-In FirebaseAuthException', | ||||||
| information: { | ||||||
| 'code': e.code, | ||||||
| 'message': e.message ?? '', | ||||||
| }); | ||||||
| throw _mapFirebaseException(e); | ||||||
| } | ||||||
| }); | ||||||
|
|
@@ -151,7 +150,8 @@ class OAuthService { | |||||
| nonce: nonce, | ||||||
| ); | ||||||
| } on SignInWithAppleAuthorizationException catch (e, stackTrace) { | ||||||
| logger.e('Apple Sign-In authorization error: ${e.code}', error: e); | ||||||
| logger.e('Apple Sign-In authorization error: ${e.code} - ${e.message}', | ||||||
| error: e); | ||||||
|
|
||||||
| if (e.code == AuthorizationErrorCode.canceled) { | ||||||
| return const Left(Failure.cancel()); | ||||||
|
|
@@ -162,9 +162,11 @@ class OAuthService { | |||||
| reason: 'Apple Sign-In authorization failed', | ||||||
| information: { | ||||||
| 'code': e.code.name, | ||||||
| 'message': e.message, | ||||||
| }, | ||||||
| ); | ||||||
| return const Left(Failure.unauthorizedError()); | ||||||
| return Left(Failure.badRequest( | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changing from 'unauthorizedError' to 'badRequest' with a string message is a functional change. Ensure the UI layer is prepared to display this raw error message to users, as 'e.message' from Apple might contain technical jargon.
Suggested change
|
||||||
| error: 'Apple Sign-In failed (${e.code.name}): ${e.message}')); | ||||||
| } | ||||||
|
|
||||||
| return RepositoryErrorHandler.handleApiCall<UserEntity>(() async { | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While enabling collection is good for production, hardcoding 'true' here might override environment-specific configurations (e.g., disabling crashlytics in dev). Consider using a configuration flag.