Skip to content

Fix/remove grid#21

Open
AntTra wants to merge 6 commits intomainfrom
fix/remove_grid
Open

Fix/remove grid#21
AntTra wants to merge 6 commits intomainfrom
fix/remove_grid

Conversation

@AntTra
Copy link
Copy Markdown
Contributor

@AntTra AntTra commented Apr 8, 2026

Thresholding dependent on HSV instead of single green channel. Changed order of operations to thresholding -> inpaint -> optional binary thresholding

@AntTra AntTra requested review from kluge7 and sophia-mina April 8, 2026 16:20
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (1b51807) to head (7d0fd65).

Files with missing lines Patch % Lines
...nclude/image_filtering/lib/filters/remove_grid.hpp 0.00% 24 Missing ⚠️
image-filtering/src/ros/image_filtering_ros.cpp 0.00% 14 Missing ⚠️
...e/image_filtering/lib/filters/binary_threshold.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #21   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         21      21           
  Lines        490     504   +14     
  Branches      39      39           
=====================================
- Misses       490     504   +14     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/image_filtering/lib/filters/binary_threshold.hpp 0.00% <0.00%> (ø)
image-filtering/src/ros/image_filtering_ros.cpp 0.00% <0.00%> (ø)
...nclude/image_filtering/lib/filters/remove_grid.hpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread image-filtering/config/image_filtering_params.yaml Outdated
Comment thread image-filtering/include/image_filtering/lib/filters/binary_threshold.hpp Outdated
kluge7 and others added 2 commits April 10, 2026 17:51
Clarified comments for hsv saturation and value adjustments.
Comment thread image-filtering/include/image_filtering/lib/filters/binary_threshold.hpp Outdated
Clarify the calculation of threshold value in the apply_filter method.
@AntTra AntTra requested a review from kluge7 April 16, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants