Fix/mobile nav links - #101
Open
vanshaj2023 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
Description
Mobile navigation links had
href=""on line 123 oftemplates/navigation/header.html, causing all mobile menu linksto point to the current page instead of their intended destination.
The desktop navigation already correctly uses
href="{{ link.value.get_url }}".This fix applies the same pattern to the mobile nav, making both consistent.
This is a regression of #14 which was previously closed as fixed.
AI usage:
Claude (claude-sonnet-4-6) was used to help identify the regression and I located the issue and fix it.