Skip to content

Fix/mobile nav links #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanshaj2023 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/mobile nav links #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd60d5
Add missing <label> elements to text/email/select form fields
vanshaj2023 Mar 20, 2026
acc86a2
Fix empty href in mobile navigation links
vanshaj2023 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions templates/components/form-field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@
</ul>
{% endif %}
{% if field_type == "text" or field_type == "email" %}
<input
{% if field.label %}
<label for="{{ field.id_for_label }}" class="block text-sm md:text-base font-medium leading-7 mb-1">
{{ field.label }}
</label>
{% endif %}
<input
id="{{ field.id_for_label }}"
class="text-base placeholder:text-base p-3.5 border border-mackerel-200 bg-white dark:bg-mackerel-100 dark:text-white placeholder:text-mackerel-400 dark:placeholder:text-white w-full rounded-[30px] min-h-[50px]"
type="text"
name="{{ field.name }}"
Expand All @@ -30,8 +36,13 @@
{% endif %}
/>
{% elif field_type == "select" %}
{% if field.label %}
<label for="{{ field.id_for_label }}" class="block text-sm md:text-base font-medium leading-7 mb-1">
{{ field.label }}
</label>
{% endif %}
<div class="relative">
<select name="{{ field.name }}" class="text-base placeholder:text-base p-3.5 flex items-center border border-mackerel-200 bg-white dark:bg-mackerel-100 dark:text-white placeholder:text-mackerel-400 dark:placeholder:text-white rounded-[30px] appearance-none w-full cursor-pointer min-h-[50px]">
<select id="{{ field.id_for_label }}" name="{{ field.name }}" class="text-base placeholder:text-base p-3.5 flex items-center border border-mackerel-200 bg-white dark:bg-mackerel-100 dark:text-white placeholder:text-mackerel-400 dark:placeholder:text-white rounded-[30px] appearance-none w-full cursor-pointer min-h-[50px]">
{% if field.label %}
<option value="">{{ field.label }}</option>
{% endif %}
Expand Down
2 changes: 1 addition & 1 deletion templates/navigation/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
hover:decoration-white
decoration-[1.5px]
"
href=""
href="{{ link.value.get_url }}"
>
{{ link.value.get_title }}
</a>
Expand Down