perf(terminal): use RestoreBlocks stage in insert_restored_block

[acarl005]

Description

Part of a stack of performance fixes for #9799.

This PR: insert_restored_block was calling restore_block with BootstrapStage::PostBootstrapPrecmd, which causes Block::new to set PerformResetGridChecks::Yes (the Windows ConPTY path). This meant a redundant disable_reset_grid_checks() call was needed afterward before parsing the serialized command/output bytes.

Passing BootstrapStage::RestoreBlocks instead is semantically correct (these blocks are being restored, not coming in post-bootstrap), and since RestoreBlocks.is_done() == false, Block::new sets PerformResetGridChecks::No automatically. The now-redundant disable_reset_grid_checks() call inside restore_block is removed.

Linked Issue

Fixes #9799

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

Manually loaded a conversation with 3014 AI exchanges and verified correct rendering of restored blocks.

• I have manually tested my changes locally with ./script/run

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

[acarl005]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• perf(terminal): use RestoreBlocks stage in insert_restored_block #13112 👈 (View in Graphite)
• perf(ai): O(1) exchange_with_id via exchange_id_index #13111 : 1 other dependent PR (#13113 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[acarl005]

/oz-review

[oz-for-oss]

@acarl005

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR changes restored block insertion to use BootstrapStage::RestoreBlocks and removes the unconditional reset-grid-check disable from restore_block.

Concerns

• Removing disable_reset_grid_checks() inside restore_block affects existing shared-session scrollback callers that still restore blocks with BootstrapStage::PostBootstrapPrecmd, leaving Windows reset-grid assertions enabled while replaying serialized bytes.
• This is user-facing terminal restoration behavior, but the PR description only includes textual manual testing. For this user-facing change, please include screenshots or a short recording demonstrating restored blocks rendering correctly end to end.
• No approved spec context was provided, and the supplemental security pass found no additional security issues.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

⚠️ [IMPORTANT] This removal applies to all restore_block callers, but shared-session scrollback still passes BootstrapStage::PostBootstrapPrecmd; on Windows that keeps reset-grid checks enabled while replaying serialized command/output bytes that do not necessarily include a reset-grid OSC. Keep this disable for the PostBootstrapPrecmd restore paths, or otherwise limit the optimization to RestoreBlocks callers.