perf(terminal): O(1) is_any_ai_block_focused via ancestor set

[acarl005]

Description

Part of a stack of performance fixes for #9799.

This PR: is_any_ai_block_focused in terminal/view.rs was called on every render of a terminal view that contains AI blocks. It iterated all N AI block IDs and called is_self_or_child_focused on each, which internally called view_ancestors() — an O(depth) walk of the view tree — each time. With 3000+ AI blocks, this was O(N × depth) per render.

Now computes view_ancestors once into a HashSet<EntityId>, then checks each AI block ID against the set in O(1), making the function O(N) total (and dominated by the O(depth) setup, which is constant relative to N).

Linked Issue

Fixes #9799

• The linked issue is labeled ready-to-spec or ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

Manually loaded a conversation with 3014 AI exchanges and confirmed smoother scrolling/rendering.

• I have manually tested my changes locally with ./script/run

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

[acarl005]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• perf(terminal): bulk_insert_restored_blocks to amortise BlockMetadataReceived #13116
• perf(ai): skip live-only subscriptions for restored AI blocks #13115
• perf(ai): guard update_imported_comments_disabled_state with conversation registry #13114
• perf(terminal): O(1) is_any_ai_block_focused via ancestor set #13113 👈 (View in Graphite)
• perf(ai): O(1) exchange_with_id via exchange_id_index #13111 : 1 other dependent PR (#13112 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@acarl005

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR optimizes TerminalView::is_any_ai_block_focused by computing the focused view's ancestor chain once and checking AI block handles against that set instead of walking the focus ancestry for each rich content view.

Concerns

No blocking concerns found. The new implementation preserves the existing self-or-child semantics because view_ancestors includes the focused view itself, and no approved spec context was available for additional implementation/spec validation.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz