Conversation
convert liquid lens source into zephyr driver Signed-off-by: Cyril Fougeray <cyril.fougeray@toolsforhumanity.com>
|
@codex review |
|
@fouge this potentially can improve our focus settling time on ir eye right? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c57f9bc84d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const uint32_t vrefint_mv = 1212; | ||
| return (uint32_t)(vrefint_mv * ADC_MAX_VALUE) / vrefint_raw; |
There was a problem hiding this comment.
The new get_vref_mv_from_raw() path now derives VREF from a hardcoded typical 1.212V constant, which drops the board/hardware-specific calibration previously used for this current feedback path. On units where VREFINT differs from the typical value (or on Pearl EV5 where a fixed calibrated VREF was used), the measured lens current becomes biased, so the PI controller will settle at the wrong physical current and can shift focus behavior across devices. Please use the existing calibrated conversion source instead of this generic approximation.
Useful? React with 👍 / 👎.
2 participants
convert liquid lens source into zephyr driver
fixes ORBS-936