Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1468 +/- ##
==========================================
- Coverage 99.66% 99.41% -0.26%
==========================================
Files 179 181 +2
Lines 23591 23750 +159
Branches 3815 3839 +24
==========================================
+ Hits 23513 23611 +98
- Misses 70 124 +54
- Partials 8 15 +7
🚀 New features to boost your workflow:
|
|
A couple of comments on your first attempt to restore; if we're going to bring it back as it was that will contradict the original setup a bit...
Thoughts? |
|
Thanks for your feedback! I will take care of points 1 and 2. Regarding the conflicts in points 3 and 4, I mentioned them in the PR description. I'm unsure which parts are outdated, so I hoped someone with more knowledge can help out. But I'll see what I can do on my own. I'll try to work on that tomorrow. If I don't manage, I can only get back to it about one week later |
05ef91f to
508309c
Compare
|
I removed the possibility to provide XEPs, and implemented the new plugin functions. I'll try to take care of the merge issues in the next days. By the way, the demo plugin wiki pages don't mention the new functions. You might want to add them there |
The line concerning XMPP was part of a block for RHEL 7. That block has been removed in commit 00afe4e, so that line isn't relevant anymore
|
I removed the merge conflicts. However, I now noticed that the tests have been previously skipped because I didn't run them in the environment that contained Slixmpp. When I actually ran them, they failed, so I'll have to look into that |
|
Closing in favor of #1505 ; Thank you for all of your hard work here. Your intentions were really great! |
|
Thank you so much for picking up the issue, and fixing everything properly! I'm very happy to have XMPP working again after those four years 🎉 |
Description:
Related issue (if applicable): #497
I have updated the code according to the Slixmpp documentation to make it work with version 1.12.0.
You might want to go through the commits one by one to see which changes I had to make.
Checklist
tox -e lintand eventox -e formatto autofix what it can)tox -e minimal)Testing
I have successfully verified this by installing Slixmpp 1.12.0 via Pipenv, and calling:
I would need support with the following tasks:
README.md(e.g. theandjidparameter doesn't seem to work)packaging/redhat/python-apprise.spec