[WIP] Revert "Removal of XMPP support due to instability"#743
[WIP] Revert "Removal of XMPP support due to instability"#743
Conversation
|
Please don't spend too much time on this. I'm not really keen on reinstating slixxmpp. I don't want your efforts to be in vain. Or would you be experimenting with xmpppy after you restore this old shell? |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 113 115 +2
Lines 14548 14712 +164
Branches 2964 2794 -170
==========================================
+ Hits 14548 14712 +164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The test cases now work properly on my machine. Both when run on macOS (Python 3.10.8), or when run via Docker. However, the outcome of the tests on CI is really weird.
It fails constantly on both Linux and macOS. Even more weird is that it apparently actually works on Windows? Do you have any clue, Chris?
Is it this what you are warning me about? |
When addressing multiple recipients, use the same session to the SMTP server as designated with the Apprise URL. In this way, subsequent full roundtrips will be saved. As many SMTP servers are employing connection rate limiting, as well as connection accept delays, this will considerably improve both robustness and performance.
This reverts commit df15de1.
amotl
force-pushed
the
collab/bring-back-xmpp
branch
from
5720616 to
0df6f08
Compare
|
It's many things. If you try to connect to a host that isn't resolvable, it hangs indefinitely. There are just many, many issues. I applaud your efforts to reinstate this code, but unless we swap the backend for something else, your efforts were in vain. |
|
See #511 (comment) for some of the insight on the errors, but they were summarized more on the PR you're basing this one off of where i pulled everything out. The fix you pointed out did not seem (at the time) to solve the problem as providing an invalid host still caused an indefinite hang. the other problem was that it very much takes over the async main loop and closes it at the end of it's call. This would bust apprise. I think Slixmpp is a great piece of development, but it's a full solution to XMPP where Apprise just needs to be able to connect, send a notification an disconnect. 90% of the supported I want to avoid adding dependencies in the Chris |
I agree.
I see your point. Still, if a library implements a protocol well, where a significant portion of getting it right is obliged to the client side, we should not rule out using corresponding libraries. This is in contrast to services "just" providing a HTTP API.
In the case of XMPP (and maybe others), I am not completely sure. Let's close this PR, to avoid lingering. I may try an implementation based on xmpppy the other day, if you agree. |
5 participants
Just some hacking. This reverts commit df15de1.