Skip to content

Removal of XMPP support due to instability#619

Merged
caronc merged 1 commit intomasterfrom
xmpp-removal
Jul 3, 2022
Merged

Removal of XMPP support due to instability#619
caronc merged 1 commit intomasterfrom
xmpp-removal

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Jul 1, 2022

Description:

Related issue (if applicable): #455, #497, #553, and #511

This plugin has not been stable enough to maintain. In it's current state it relies on a third party library which works but has it's own outstanding issues that causes Apprise to hang indefinitely (such as providing a hostname that doesn't exist, or an unresponsive upstream service where a connection never gives up).

To this day, I'm not aware of the Apprise XMPP service functioning properly to the users who have requested it. 🙁

XMPP support will return to apprise eventually, but it will be a dumb'ed down version that just opens a connection to the server, posts the content and closes. At this time the overhead of existing libraries are too complex for the goal attempted to be achieved here.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #619 (df15de1) into master (1519e98) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #619   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          112       110    -2     
  Lines        14416     14407    -9     
  Branches      2725      2752   +27     
=========================================
- Hits         14416     14407    -9     
Impacted Files Coverage Δ
apprise/plugins/__init__.py 100.00% <ø> (ø)
apprise/conversion.py 100.00% <0.00%> (ø)
apprise/plugins/NotifyPushover.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1519e98...df15de1. Read the comment docs.

@caronc
Copy link
Owner Author

caronc commented Jul 1, 2022

@amotl: Just for your review since you're well versed in this area. do you have any last suggestions before i pull this out. I will re-visit this as a more light-weight solution later on.

Thoughts?

@amotl
Copy link
Collaborator

amotl commented Aug 22, 2022

Dear Chris,

thanks for giving me notice about it. I think it is sad, but c'est la vie, right? When checking the upstream code base, I discovered a patch I shared with you over at #511 (comment).

With kind regards,
Andreas.

@stevenroose
Copy link

Is there a tracking issue for adding back XMPP support?

@Neustradamus
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants