Conversation
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 112 110 -2
Lines 14416 14407 -9
Branches 2725 2752 +27
=========================================
- Hits 14416 14407 -9
Continue to review full report at Codecov.
|
|
@amotl: Just for your review since you're well versed in this area. do you have any last suggestions before i pull this out. I will re-visit this as a more light-weight solution later on. Thoughts? |
|
Dear Chris, thanks for giving me notice about it. I think it is sad, but c'est la vie, right? When checking the upstream code base, I discovered a patch I shared with you over at #511 (comment). With kind regards, |
|
Is there a tracking issue for adding back XMPP support? |
This reverts commit fcedb47. WIP: Fix conflicts in RPM specification
Description:
Related issue (if applicable): #455, #497, #553, and #511
This plugin has not been stable enough to maintain. In it's current state it relies on a third party library which works but has it's own outstanding issues that causes Apprise to hang indefinitely (such as providing a hostname that doesn't exist, or an unresponsive upstream service where a connection never gives up).
To this day, I'm not aware of the Apprise XMPP service functioning properly to the users who have requested it. 🙁
XMPP support will return to apprise eventually, but it will be a dumb'ed down version that just opens a connection to the server, posts the content and closes. At this time the overhead of existing libraries are too complex for the goal attempted to be achieved here.
Checklist
flake8)