-
Notifications
You must be signed in to change notification settings - Fork 162
Set stable toolchain & MSRV 1.85, update msgpacker #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
==========================================
+ Coverage 85.08% 85.18% +0.09%
==========================================
Files 57 57
Lines 3615 3713 +98
==========================================
+ Hits 3076 3163 +87
- Misses 539 550 +11
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the project's Rust toolchain from nightly to stable version 1.85 as the minimum supported Rust version (MSRV), and upgrades the msgpacker dependency from 0.4.3 to 0.4.8. The changes also include modernizing the code to use newer stable Rust features and cleaning up formatting configuration.
Changes:
- Updated Rust toolchain to stable and set MSRV to 1.85
- Upgraded msgpacker dependency from 0.4.3 to 0.4.8
- Replaced
map_orwithis_none_orandis_some_andmethods (stable since Rust 1.82) - Simplified lifetime parameters in trait implementations by removing redundant
'blifetimes - Added explicit type parameters to
mem::transmutefor improved clarity
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Added MSRV 1.85, blake2b_simd dependency, and upgraded msgpacker to 0.4.8 |
| rust-toolchain.toml | Changed toolchain from nightly to stable |
| src/transcript.rs | Added explicit type parameters to mem::transmute call |
| src/proof_system/linearization_poly.rs | Moved #[cfg(feature = "alloc")] attribute to proper position |
| src/fft/polynomial.rs | Updated to use is_none_or/is_some_and and simplified lifetime parameters |
| src/fft/evaluations.rs | Simplified lifetime parameters in trait implementations |
| rustfmt.toml | Removed wrap_comments configuration |
| .github/workflows/dusk_ci.yml | Renamed workflow job from nightly to stable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3516520 to
e38e961
Compare
238187a to
6abb2f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 45 out of 45 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xevisalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #859 #860 #861