Skip to content

Conversation

@HDauven
Copy link
Member

@HDauven HDauven commented Jan 24, 2026

Resolves #859 #860 #861

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.18%. Comparing base (651507a) to head (16ad7e0).

Files with missing lines Patch % Lines
src/error.rs 0.00% 3 Missing ⚠️
src/fft/polynomial.rs 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   85.08%   85.18%   +0.09%     
==========================================
  Files          57       57              
  Lines        3615     3713      +98     
==========================================
+ Hits         3076     3163      +87     
- Misses        539      550      +11     
Files with missing lines Coverage Δ
src/commitment_scheme/kzg10/commitment.rs 40.00% <ø> (ø)
src/commitment_scheme/kzg10/key.rs 85.00% <100.00%> (+1.16%) ⬆️
src/commitment_scheme/kzg10/srs.rs 85.91% <100.00%> (-1.78%) ⬇️
src/compiler.rs 98.72% <100.00%> (+0.12%) ⬆️
src/compiler/prover.rs 96.31% <ø> (-0.56%) ⬇️
src/composer/permutation.rs 90.21% <100.00%> (-1.93%) ⬇️
src/fft/domain.rs 74.65% <ø> (-0.70%) ⬇️
src/fft/evaluations.rs 39.21% <ø> (-0.79%) ⬇️
src/proof_system/linearization_poly.rs 99.09% <ø> (+0.03%) ⬆️
src/proof_system/proof.rs 95.78% <ø> (+0.66%) ⬆️
... and 30 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651507a...16ad7e0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HDauven HDauven requested a review from Copilot January 24, 2026 18:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project's Rust toolchain from nightly to stable version 1.85 as the minimum supported Rust version (MSRV), and upgrades the msgpacker dependency from 0.4.3 to 0.4.8. The changes also include modernizing the code to use newer stable Rust features and cleaning up formatting configuration.

Changes:

  • Updated Rust toolchain to stable and set MSRV to 1.85
  • Upgraded msgpacker dependency from 0.4.3 to 0.4.8
  • Replaced map_or with is_none_or and is_some_and methods (stable since Rust 1.82)
  • Simplified lifetime parameters in trait implementations by removing redundant 'b lifetimes
  • Added explicit type parameters to mem::transmute for improved clarity

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Added MSRV 1.85, blake2b_simd dependency, and upgraded msgpacker to 0.4.8
rust-toolchain.toml Changed toolchain from nightly to stable
src/transcript.rs Added explicit type parameters to mem::transmute call
src/proof_system/linearization_poly.rs Moved #[cfg(feature = "alloc")] attribute to proper position
src/fft/polynomial.rs Updated to use is_none_or/is_some_and and simplified lifetime parameters
src/fft/evaluations.rs Simplified lifetime parameters in trait implementations
rustfmt.toml Removed wrap_comments configuration
.github/workflows/dusk_ci.yml Renamed workflow job from nightly to stable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HDauven HDauven force-pushed the stable-tool-chain-msrv branch from 3516520 to e38e961 Compare January 24, 2026 18:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to Rust edition 2024 Set MSRV that is Edition 2024 compatible Move Plonk to stable toolchain

2 participants